Normalize encoded URL paths. - #14
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
normalize-path-components
branch
from
August 12, 2026 22:25
5dc3b00 to
2fe72ab
Compare
samuel-williams-shopify
force-pushed
the
normalize-path-components
branch
2 times, most recently
from
August 13, 2026 01:09
5293546 to
fad701a
Compare
samuel-williams-shopify
force-pushed
the
normalize-path-components
branch
from
August 13, 2026 01:17
fad701a to
bc7c74a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Protocol::URL::Path#normalizebehavior based on the path segment grammarsimplifyremains an explicit application-level operationTesting
bundle exec bake testbundle exec rubocop lib/protocol/url/path.rb test/protocol/url/path.rbPerformance
The direct normalization pass is approximately 1.1-2.2x faster than decode/re-encode on representative paths and allocates substantially fewer objects.