Repository navigation
feat: Make tgpu.declare dereferenceable - #3293
Conversation
|
pkg.pr.new packages benchmark commit |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.80, 1.61, 3.43, 5.44, 6.33, 9.48, 19.83, 18.15]
line [0.77, 1.60, 3.50, 5.28, 6.12, 10.63, 19.75, 18.05]
line [0.76, 1.54, 3.18, 5.31, 5.98, 9.16, 18.65, 18.61]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.22, 0.47, 0.56, 0.75, 0.96, 0.97, 1.21, 1.28]
line [0.22, 0.39, 0.59, 0.69, 0.90, 0.92, 1.14, 1.24]
line [0.23, 0.42, 0.54, 0.67, 0.92, 0.95, 1.13, 1.26]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.73, 1.81, 3.22, 5.78, 9.98, 21.07, 45.48, 93.43]
line [0.72, 1.64, 3.03, 5.64, 10.81, 21.52, 45.45, 90.67]
line [0.72, 1.59, 2.79, 4.92, 9.49, 20.09, 44.28, 86.90]
|
Bundle size comparison (
|
| 🟢 Decreased | ➖ Unchanged | 🔴 Increased (max 0.08%) | ❔ Unknown |
|---|---|---|---|
| 0 | 349 | 6 | 0 |
No notable changes.
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
iwoplaza
left a comment
There was a problem hiding this comment.
Looks good! Just the nit surfaced by Froggy and we're good
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
Since the prior pullfrog review (7e35149), the only change to a PR file is a type-only addition that resolves the outstanding [$gpuValueOf] consistency nit:
TgpuDeclarenow declares[$gpuValueOf].readonly [$gpuValueOf]: InferGPU<Void>was added to theTgpuDeclareinterface and the matchingdeclare readonly [$gpuValueOf]: InferGPU<Void>prototype declaration onTgpuDeclareImpl, plus the$gpuValueOfimport — mirroringTgpuRawCodeSnippet/TgpuVariableexactly. No runtime change:makeDereferenceablealready defines the accessor on the prototype.
I verified pnpm --filter typegpu test:types passes at this head.
deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

Uh oh!
There was an error while loading. Please reload this page.