Skip to content

fix: correct recorder revive after connecting different source - #1201

Open
mdydek wants to merge 3 commits into
mainfrom
fix/reviving-correct-recorder-after-conf-change
Open

fix: correct recorder revive after connecting different source#1201
mdydek wants to merge 3 commits into
mainfrom
fix/reviving-correct-recorder-after-conf-change

Conversation

@mdydek

@mdydek mdydek commented Jul 30, 2026

Copy link
Copy Markdown
Member

Closes #1179

⚠️ Breaking changes ⚠️

Introduced changes

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

@mdydek mdydek changed the title fix: first implementation fix: correct recorder revive after connecting different source Jul 30, 2026
@mdydek mdydek added the fix label Jul 30, 2026
Comment on lines +152 to 155
if (fileResult.is_err()) {
if (shouldArmInput) {
[nativeRecorder_ setInputArmed:true];
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we re-arm on error?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

2 participants