Skip to content

style: unified headers extensions convention across the repo - #1203

Merged
SomePersonFromMars merged 4 commits into
mainfrom
refactor/audio-param
Aug 3, 2026
Merged

style: unified headers extensions convention across the repo#1203
SomePersonFromMars merged 4 commits into
mainfrom
refactor/audio-param

Conversation

@SomePersonFromMars

@SomePersonFromMars SomePersonFromMars commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

Closes #

⚠️ Breaking changes ⚠️

  • None for the public JS/TS API.
  • Internal C++ include paths change for a handful of renamed headers (.h.hpp). This only affects code that includes those headers directly.

Introduced changes

  • Adopt a consistent C++ header extension convention in common/cpp/audioapi/:
    • .hpp — header-only templates (class or function)
    • .h — non-template code (usually paired with a .cpp)
  • Renamed headers to match the convention:
    • .h.hpp: CompositeAudioParam, RuntimeInstanceCache, AudioEventPayloadMapping, TypedAudioNodePtr
    • .hpp.h: AudioUtils, ParamRenderEventFactory
  • Updated all affected #include paths across the native engine, tests, and worklets package.
  • Documented the convention in build-compilation-dependencies and updated related skill references (audio-nodes, utilities, thread-safety-itc).

Checklist

  • Linked relevant issue
  • Updated relevant documentation
  • Added/Conducted relevant tests
  • Performed self-review of the code
  • Updated Web Audio API coverage
  • Added support for web
  • Updated old arch android spec file

This is to ensure we match templates-related convention.
@SomePersonFromMars
SomePersonFromMars marked this pull request as draft July 30, 2026 15:05
@SomePersonFromMars
SomePersonFromMars marked this pull request as ready for review July 31, 2026 08:09
@SomePersonFromMars SomePersonFromMars changed the title style: renamed header to CompositeAudioParam.hpp style: unified headers extensions convention across the repo Jul 31, 2026

@closetcaiman closetcaiman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

it's always good to have these things sorted out!!

@SomePersonFromMars
SomePersonFromMars merged commit ed5ccb1 into main Aug 3, 2026
9 checks passed
@SomePersonFromMars
SomePersonFromMars deleted the refactor/audio-param branch August 3, 2026 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants