fix: render queue event resolution - #1207
Open
closetcaiman wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1191
AudioParam.valuesetter will have stricter curve checks (literally the same assetValueAtTime) as per spec:Introduced changes
AudioParam.valuesetter now invokessetValueAtTime(value, context.currentTIme)automation eventwith nostartValue(likesetTargetAtTimeorRAMPevents) was scheduled without an explicitsetValueAtTimecall. In result, such event'sstartValuefallbacked todefaultValue_which then created audible jumps in pitch and sidebands infftanalysis.Other
Note
Identified issues with
WEB IDLtype checking. For example, currentlynumber.isFinite()is rarely (if ever) called to check the passed values. Solving this may probably improvewpttests results.Checklist