Repository navigation
Conversation
- Regenerate the diagnostics reference from solid next 6cca8b57: adds STORE_WRITE_OUTSIDE_SETTER (#4194) and UNCOMMITTED_INPUT_OVERWRITTEN (#4205), drops BINDING_SLOT_POSITION (binding slots were removed), and picks up skill edits to EFFECT_RELAY_TEAR, LOWERCASE_EVENT_ATTRIBUTE, REACTIVITY_HALTED, SSR_BOUNDARY_WATERFALL and SSR_LIVE_HOLE_LATCHED. The generator's FIX_STARTS entry for SSR_BOUNDARY_WATERFALL follows the skill's new capitalization, and the dead BINDING_SLOT_POSITION entry goes. - The Vite plugin no longer defaults test.environment to jsdom (vite-plugin-solid #459): the testing guide drops the "browser mode still needs jsdom" note and troubleshooting entry, browser mode no longer installs jsdom, and a new entry covers `document is not defined`. The plugin options reference and the Solid 1 migration guide say to set the environment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01R9d4iekBWmtH343gNAGJpd
|
|
✅ Deploy Preview for solid-docs-v2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Description(required)
Diagnostics reference. I regenerated it with
scripts/extract-diagnostics.mjsagainst solidnextat 6cca8b57.STORE_WRITE_OUTSIDE_SETTER(solid #4194) andUNCOMMITTED_INPUT_OVERWRITTEN(solid #4205).BINDING_SLOT_POSITION, since binding slots were removed upstream.EFFECT_RELAY_TEAR,LOWERCASE_EVENT_ATTRIBUTE,REACTIVITY_HALTED,SSR_BOUNDARY_WATERFALLandSSR_LIVE_HOLE_LATCHED.FIX_STARTSentry forSSR_BOUNDARY_WATERFALLnow matches the skill's new capitalization (the run failed without this), and I deleted the deadBINDING_SLOT_POSITIONentry.Vite plugin test environment.
@solidjs/vite-pluginno longer defaultstest.environmentto jsdom (vite-plugin-solid #459).document is not defined.vite-plugin-solid/options: the Vitest bullet now says the plugin doesn't set the environment.test.environment" and says to set it.These pages are what the From React additions in #1664 need to link to (both new codes).
lint:tone(only a pre-existing generated warning remains),check:lintand prettier all pass.Related issues & labels
Generated by Claude Code