Repository navigation
fix: inline Solid packages declared at the workspace root - #435
Merged
Merged
Conversation
- vitefu only crawled the package.json at the Vite root. - In a workspace, a project can import packages that only the workspace root declares. - Those packages were left external, so Vitest loaded their .jsx files with Node and failed with `Unknown file extension ".jsx"`. - The plugin now also crawls the workspace root and adds its framework packages to `ssr.noExternal`. Fixes #157 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 4f2d418 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
…t-solid-deps # Conflicts: # examples/start-ssr/test/run.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #157 on
next. The fix formain(1.x) is in a separate PR.In a workspace, a Solid package declared only in the workspace root's
package.jsonis now inlined. Before, Vitest left it external, Node loaded its raw.jsxfiles, and tests failed withUnknown file extension ".jsx".Cause
crawlFrameworkPkgsonly reads thepackage.jsonat the Vite root.package.jsondoes not list.ssr.noExternal, which Vitest 4 and later uses to build its inline list.Changes
searchForWorkspaceRoot(root)differs from the project root, the plugin also crawls the workspace root'spackage.json.ssr.noExternalentries from that crawl are merged.optimizeDeps.includeentries must resolve from the project root, so they are not added.Testing
vitest.config.tswithprojects: ['modules/*'], and@solidjs/routerdeclared only in the rootpackage.json.TypeError: Unknown file extension ".jsx" for .../@solidjs/router/dist/routers/...jsx.vitest/workspace-root-pkgscheck toexamples/start-ssr/test/run.mjs. It resolves the config for a temporary workspace and fails without the fix.pnpm test:unitandnode test/run.mjs vitestpass. The fullstart-ssrbrowser suite was not completed locally.🤖 Generated with Claude Code