Repository navigation
Conversation
- Add a root vitest config and a test:unit script, matching the next branch. - Run the unit tests in the vitest workflow. - Exclude test files from the declaration build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- resolve.dedupe was only set while serving, so a dependency with its own nested solid-js copy was bundled twice in production. - Dedupe solid-js in every command. optimizeDeps.include stays dev only. - Add a build test with a nested solid-js copy. Fixes #112 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 62e2b75 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112 on
main(1.x). The fix fornextis in a separate PR.Production builds now include one copy of
solid-jswhen a dependency brings its own version. Before,resolve.dedupewas only set for the dev server, so builds could bundle two copies.Changes
resolve.dedupeforsolid-jsis now set for every command, not onlyserve.optimizeDeps.includestays dev-only.Testing
vitest runandtsc --noEmitpass. Thevite-5,vite-6andvite-8examples build.Note on the first commit
mainhad no unit tests. The first commit adds the same Vitest setup thatnextuses: a rootvitest.config.ts, atest:unitscript, and a step in the Vitest workflow. The othermainfix PRs from this batch (#112, #153, #206, #130, #141) share this exact commit, so they do not conflict on it.🤖 Generated with Claude Code