Repository navigation
fix: resolve Solid server builds for webworker SSR targets - #441
Merged
Merged
Conversation
- With ssr.target set to webworker, Vite gives the ssr environment the client conditions, so solid-js and @solidjs/web resolved to their browser builds and renderToString threw. - Add the worker export condition to that environment. Solid maps worker to its server build. - Add build tests for the webworker and node targets. Fixes #153 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: c10fe96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153 on
next. The fix formain(1.x) is in a separate PR.An SSR build with
ssr.target: 'webworker'now bundles the server build of Solid. Before, it bundled the browser build, soisServerwas false andrenderToStringthrew.Cause
ssr.target: 'webworker', Vite gives the SSR environment the client resolve conditions.resolve.conditionsno longer reaches the SSR environment.workercondition.Changes
workerto the SSR environment's conditions when it targetswebworker.Testing
vitest runandtsc --noEmitpass.🤖 Generated with Claude Code