Repository navigation
Conversation
- Add a root vitest config and a test:unit script, matching the next branch. - Run the unit tests in the vitest workflow. - Exclude test files from the declaration build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- With ssr.target set to webworker, the SSR build resolved the browser build of solid-js and renderToString threw. - Vite 6+: add the worker export condition to the ssr environment. - Vite 4 and 5: set ssr.resolve.conditions with the worker condition, keeping the top-level conditions it replaces. - Add build tests for the webworker and node targets. Fixes #153 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 9c17655 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #153 on
main(1.x). The fix fornextis in a separate PR.An SSR build with
ssr.target: 'webworker'now bundles the server build ofsolid-js. Before, it bundled the browser build, soisServerwas false andrenderToStringthrewnot supported in the browser.Cause
ssr.target: 'webworker', Vite gives the SSR environment the client resolve conditions.resolve.conditionsno longer reaches the SSR environment.solid-jsputs its server build under theworkercondition.Changes
workerto the SSR environment's conditions.ssr.resolve.conditions, keeping the top-level conditions that option replaces.ssr.resolve.conditionsoption and is not covered.Testing
vitest runandtsc --noEmitpass.Note on the first commit
mainhad no unit tests. The first commit adds the same Vitest setup thatnextuses: a rootvitest.config.ts, atest:unitscript, and a step in the Vitest workflow. The othermainfix PRs from this batch (#112, #153, #206, #130, #141) share this exact commit, so they do not conflict on it.🤖 Generated with Claude Code