Repository navigation
Conversation
- The transform stripped the query before checking the extension. Ids like unplugin-icons' `~icons/mdi/folder?width=2em.tsx` then had no extension, so Vite compiled their JSX for React. - When the query-free path is not a JSX file but the full id is, compile the full id. - Read custom extensions from the query-free path. A dot in the query (`a.mdx?x=1.5`) was read as the extension and the module was skipped. - Add dev transform tests for both cases. Fixes #206 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: e01a6b3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206 on
next. The fix formain(1.x) is in a separate PR.Icons from
unplugin-iconswithcompiler: 'solid'and a query, such as~icons/mdi/folder?width=2em, are compiled by Solid again. They were left to Vite's default JSX transform, which emits React code.Cause
unplugin-iconsputs the extension after the query:~icons/mdi/folder?width=2em.tsx.Changes
getExtensionnow removes the query before it looks for the extension. Before, a custom extension followed by a query containing a., such asa.mdx?x=1.5, was skipped.Testing
react/jsx-dev-runtime, and the dev server returned 500. Published 2.11.1 compiled it correctly.vitest runandtsc --noEmitpass. Thevite-8,ssrandstart-ssrexamples build.🤖 Generated with Claude Code