Repository navigation
Conversation
- Add a root vitest config and a test:unit script, matching the next branch. - Run the unit tests in the vitest workflow. - Exclude test files from the declaration build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
- The plugin turned the user's alias object into an array and added its own alias array. Vite merges an array with a later plugin's alias object by putting the later aliases first, so a plugin alias for `path` matched `path/posix` before the user's own `path/posix` alias. - Stop rewriting the user's aliases and drop the plugin's own alias. The `solid-refresh` import is resolved in resolveId instead. - Add a build test with a later plugin alias, and a dev test that the HMR runtime still resolves. Fixes #130 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: f8439e8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130 on
main(1.x).nextalready stopped rewriting aliases in d684795 and is not affected.A user's
resolve.aliasentries now keep priority over aliases added by later plugins. Before,vite-plugin-node-polyfillswith a user alias{ 'path/posix': 'path-browserify' }failed withCould not load .../path-browserify/posix.Cause
mergeAliasmerges two alias objects by key. When it merges an object into an array, the later plugin's aliases come first, so they won over the user's.solid-refreshalias was an array too, and caused the same reordering.Changes
solid-refresh. It resolvessolid-refreshinresolveIdinstead.Testing
vitest runandtsc --noEmitpass.Note on the first commit
mainhad no unit tests. The first commit adds the same Vitest setup thatnextuses: a rootvitest.config.ts, atest:unitscript, and a step in the Vitest workflow. The othermainfix PRs from this batch (#112, #153, #206, #130, #141) share this exact commit, so they do not conflict on it.🤖 Generated with Claude Code