Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016PFhdmTPKsQSS3fENqTi5b
🦋 Changeset detectedLatest commit: 711c918 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
This PR is stacked on #437, which is stacked on #433. Merge those first. GitHub then retargets this PR to
next.Problem
In test mode, the plugin set
test.environment: 'jsdom'whenever the config left the environment unset, except in browser mode or a projects root. OpenClaw's Solid 2 migration added the plugin to a shared config that their Node-only Vitest suites also load, because those tests import UI renderers. About 25 database-worker shards then ran under jsdom and failed with errors that were hard to trace ("The URL must be of scheme file", corrupt worker frames). Other framework plugins leave Vitest'snodedefault alone.Change
test.environment. Projects setjsdomorhappy-domfor DOM component tests themselves.nodeoredge-runtimestill selects the server posture.examples/start-ssr: the non-projects config setsenvironment: 'jsdom'explicitly. Thebrowser-envcheck now asserts that no environment is injected in either case. It resolves without the config file, so it would fail on the old default.Testing
node test/run.mjs vitestinexamples/start-ssr: 8/8 pass.pnpm test:unit: 21 passed.tsc --noEmitis clean. Prettier warnings onsrc/index.ts,README.mdandrun.mjsare the same as on the base branch.Generated by Claude Code