Repository navigation
test(start-ssr): update dedupe.mjs for the #439/#458 dedupe rules - #461
Merged
Merged
Conversation
#439 dedupes solid-js, @solidjs/web and @solidjs/signals in builds too, each only when the root resolves it, and #458 pre-bundles @solidjs/signals when the root has a copy. The config test still asserted the old dev-only rules, which fails the Release workflow's Start SSR suite on every push to next. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zVakGXNk835Dj1yu5kGgE
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
The Release workflow has failed on every push to
nextsince #439. It fails in the Start SSR suite, inexamples/start-ssr/test/dedupe.mjs. Because the job stops there, the Version Packages PR (#424) has not been refreshed and nothing can be published.The plugin is behaving as intended. The test still checks the old dev-only rules:
solid-js,@solidjs/weband@solidjs/signalsonly when the app root resolves each one, and builds now get the same list. The probe root only stubbed signals, so the "solid-js and @solidjs/web still deduped" check failed, and so did "build: dedupe is empty".@solidjs/signalsinoptimizeDeps.includewhen the root has a copy. That flips the "signals not in include" check.This change is test only:
Locally,
node test/dedupe.mjspasses 8/8. There is no plugin or runtime change and no changeset. PR CI doesn't run the example suites, so the Release run on merge is the real check.Generated by Claude Code