Repository navigation
chore: ride solid rc.16 - #462
Merged
Merged
Conversation
Bump solid-js / @solidjs/web / @solidjs/compiler / @solidjs/babel-plugin to 2.0.0-rc.16 and fix the two things the bump surfaced: - JSX source locations pointed into the code the native prelude (primitive names, lazy, refresh) had reprinted. Map them back through the prelude's sourcemap on both compiler backends; the primitives pass's own locations are already authored positions and are kept. - Start mode's production containFailure now reports through @solidjs/web's reportRequestFailure (kind 'request'), so an error the runtime already reported is not heard a second time under rc.16's per-kind ledger. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019zVakGXNk835Dj1yu5kGgE
🦋 Changeset detectedLatest commit: 0d9a0d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Moves the Solid floors from rc.14 to rc.16 in
package.jsonand thepnpm-workspace.yamlcatalog and age excludes, and regenerates the lockfile. rc.16 includes solid#4030, which moves the shell-end marker before</body>. Two plugin issues showed up with the bump:1. JSX source locations were wrong under
sourceNames.locations. rc.16's compiler is the first to takelocations, so the code path from #421 had never run against a real compiler before. The JSX transform runs after the lazy, primitive-names and refresh passes, and each of those reprints the module. The JSX locations therefore pointed into rewritten code; for example,<Home />on line 6 was reported as18:57. Running JSX first would break the primitive locations and refresh's dependency detection. Instead, a new internal helperremapJsxLocations(src/source-names.ts) maps each"file:line:col"string the JSX pass wrote back through the earlier passes' combined sourcemap, using Node's built-inmodule.SourceMap(no new dependency). It covers both the native and babel backends, and it only runs when locations are on and the code was rewritten. Tests now assert the component and binding locations for both backends.2. In-process server-function failures were reported twice in start-ssr's
containchecks (mw-prod, preview). rc.16 dedupes reports per kind and addsreportRequestFailure(error, event)to@solidjs/web. The generatedcontainFailureinsrc/ssr/index.tsnow calls it, replacing the hand-builtreportServerErrorcall, theSERVER_ERRORSsymbol lookup and the manualconsole.error, for net −4 lines. The test expectations change fromrender/failedtorequest/failed, and the README paragraph about contained failures now describes therequestkind.No new public API and no new browser runtime bytes. The changeset is
solid-rc16.md(patch).Local results on this branch (current
nextplus this commit):tsc --noEmitrun.mjs755/755, plus http-bridge, warnings, dedupe 8/8 and ssr-inlineKnown caveat: the output sourcemap isn't adjusted when a rewritten location string changes length, so later columns on that line can be off by about one character.
Generated by Claude Code