Skip to content

[next] fix: snapshot array length override fallback#2731

Closed
mathieuprog wants to merge 1 commit into
solidjs:nextfrom
mathieuprog:next
Closed

[next] fix: snapshot array length override fallback#2731
mathieuprog wants to merge 1 commit into
solidjs:nextfrom
mathieuprog:next

Conversation

@mathieuprog
Copy link
Copy Markdown
Contributor

Use nullish coalescing so snapshot preserves an overridden array length of 0 instead of falling back to the source length

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 30, 2026

⚠️ No Changeset found

Latest commit: c0b4599

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mathieuprog mathieuprog changed the title Fix snapshot array length override fallback fix: snapshot array length override fallback May 30, 2026
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 30, 2026

Merging this PR will not alter performance

✅ 118 untouched benchmarks


Comparing mathieuprog:next (c0b4599) with next (e1f3b56)

Open in CodSpeed

@mathieuprog mathieuprog changed the title fix: snapshot array length override fallback [next] fix: snapshot array length override fallback May 30, 2026
@ryansolid
Copy link
Copy Markdown
Member

Thanks @mathieuprog. I pulled this fix into next with an added regression test and changeset, and kept your contribution credited via Co-authored-by.

Merged locally as baa47d2 (fix: preserve zero snapshot array length overrides).

@ryansolid
Copy link
Copy Markdown
Member

Landed on in baa47d2 with test coverage and changeset. Thanks again!

@ryansolid ryansolid closed this Jun 3, 2026
@ryansolid
Copy link
Copy Markdown
Member

Correction: landed on the next branch in baa47d2 with test coverage and a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants