Fix hydrated innerHTML with attribute spreads#2742
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2737.
This prevents an attribute-only spread from installing a child reconciliation effect when the spread props do not include child-bearing props. During hydration, that effect could clear existing innerHTML content on the first reactive spread update.
Added a regression test that hydrates server-rendered innerHTML, updates a spread-only data attribute, and verifies the content remains intact.
Verification:
Note:
pnpm --dir packages/solid exec tsc --project web/tsconfig.build.jsonwas attempted in a fresh checkout, but it requires generated local package links/types first and failed before checking this change.