Repository navigation
Conversation
STATUS_ERROR was only cleared by a recompute or an async settle, neither of which a direct write performs, so an errored memo kept throwing the stale error to every later reader.
🦋 Changeset detectedLatest commit: e3abb80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Generated by Claude Code |
Coverage Report for CI Build 39312359126Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 77.555%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will degrade performance by 10.63%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ |
build + consume |
693.8 µs | 776.3 µs | -10.63% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing Neekoras:fix-4110-write-clears-memo-error (e3abb80) with next (3cffd86)
Footnotes
-
5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
Generated by Claude Code |
…n read (#4110) (#4167) * fix(signals): a write clears a writable memo's previous error STATUS_ERROR was only cleared by a recompute or an async settle, neither of which a direct write performs, so an errored memo kept throwing the stale error to every later reader. * fix(signals): keep a writable memo's error shown until the write commits (#4110) Builds on #4143. The error stays the display until the write commits, so a read between the write and its flush, or under the action holding it, still throws instead of returning the old value. A write also clears an error a pass staged under the same hold, so effects see the written value instead of their error arm (the action-write case left from #4148). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1 * chore(size): raise caps for the #4110 writable-memo error fix Accepted by the maintainer on 2026-10-20: about +50 B minified on the core floor. Also re-records #4163's +9 B, which merged without a re-record. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1 --------- Co-authored-by: Nicholas <nickylin211@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>
Generated by Claude Code |
Fixes #4110. Superseded by #4167, which carried the original commit from this PR with contributor credit and added the maintainer's review fixes. #4167 is merged into
next.This PR originally proposed clearing a writable memo's error on a manual write, including when the replacement equals its last good value. The review identified a torn read before commit and a held staged-error case; both were addressed in #4167. The original tests are included there.
The fork branch received additional experimental changes after this PR was closed. Those changes were not part of #4167 or its review; #4167 is the authoritative merged fix.