Repository navigation
examples: router next.41 formAction; revalidate JSDoc covers any mutation - #4172
Conversation
…idation The router examples import `formAction` instead of the deprecated router `action` and pin @solidjs/router 2.0.0-next.41. The `revalidate` JSDoc on the response helpers now says Solid Router revalidates everything after any mutation (form action or direct call), and that `""` declares nothing like an empty list. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CLHVghj7oAvSMqnq9WRKdv
Size (brotli, eager entry chunk)
|
Coverage Report for CI Build 39471629069Coverage remained the same at 77.555%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Merging this PR will degrade performance by 39.17%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | projection derive: write one NESTED field (reference) |
895.2 µs | 1,471.5 µs | -39.17% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing claude/project-thread-257vck (8d1e950) with next (5a4b2e8)2
Footnotes
-
5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
next(7f8ab2d) during the generation of this report, so 5a4b2e8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
|
CodSpeed flagged a regression in Generated by Claude Code |
Summary
Before: the router examples (chat, notes, todos-server) import the router's
action, which@solidjs/router@2.0.0-next.41deprecates in favor offormActionand which now logs a dev warning. TherevalidateJSDoc on the@solidjs/webresponse helpers says Solid Router revalidates everything "after an action".After: the examples use
formAction, and every example pins@solidjs/router2.0.0-next.41. The JSDoc says the router revalidates everything after any mutation, whether that's a form action or a direct server function call, matching router #688. It also notes that""declares nothing, the same as an empty list.This is a docs and examples change only; there is no runtime change. Router change: solidjs/solid-router#688.
How did you test this change?
solid-js,@solidjs/weband@solidjs/signalswith turbo, then rantsc --noEmitinexamples/chat,examples/notesandexamples/todos-server. All three are clean.pnpm-lock.yamlwithpnpm install --lockfile-only, andpnpm install --frozen-lockfilepasses.Generated by Claude Code