Skip to content

examples: router next.41 formAction; revalidate JSDoc covers any mutation - #4172

Merged
ryansolid merged 1 commit into
nextfrom
claude/project-thread-257vck
Oct 20, 2026
Merged

ryansolid merged 1 commit into
nextfrom
claude/project-thread-257vck

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Summary

Before: the router examples (chat, notes, todos-server) import the router's action, which @solidjs/router@2.0.0-next.41 deprecates in favor of formAction and which now logs a dev warning. The revalidate JSDoc on the @solidjs/web response helpers says Solid Router revalidates everything "after an action".

After: the examples use formAction, and every example pins @solidjs/router 2.0.0-next.41. The JSDoc says the router revalidates everything after any mutation, whether that's a form action or a direct server function call, matching router #688. It also notes that "" declares nothing, the same as an empty list.

This is a docs and examples change only; there is no runtime change. Router change: solidjs/solid-router#688.

How did you test this change?

  • Built solid-js, @solidjs/web and @solidjs/signals with turbo, then ran tsc --noEmit in examples/chat, examples/notes and examples/todos-server. All three are clean.
  • Regenerated pnpm-lock.yaml with pnpm install --lockfile-only, and pnpm install --frozen-lockfile passes.

Generated by Claude Code

…idation

The router examples import `formAction` instead of the deprecated router
`action` and pin @solidjs/router 2.0.0-next.41. The `revalidate` JSDoc on
the response helpers now says Solid Router revalidates everything after any
mutation (form action or direct call), and that `""` declares nothing like
an empty list.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CLHVghj7oAvSMqnq9WRKdv
@github-actions

Copy link
Copy Markdown

Size (brotli, eager entry chunk)

scenario head vs base minified vs base minified vs recorded cap lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush) 7.37 KB 0 B 0 B 0 B 7.39 KB ✅
signals: + createStore 14.93 KB 0 B 0 B 0 B 14.95 KB ✅
signals: + isPending/latest 10.14 KB 0 B 0 B 0 B 10.16 KB ✅
signals: + until/refresh (truth readers, no optimism) 7.97 KB 0 B 0 B 0 B 7.98 KB ✅
app: render + one signal (the simple-app floor) 9.68 KB 0 B 0 B 0 B 9.70 KB ✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy 18.31 KB 0 B 0 B 0 B 18.32 KB ✅ lazy-page.js 0.04 KB
app: hydrating + every store primitive family 30.31 KB 0 B 0 B 0 B 30.32 KB ✅ lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy 13.26 KB 0 B 0 B 0 B 13.28 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the observe artifacts) 15.02 KB 0 B 0 B 0 B 15.03 KB ✅ lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled 29.61 KB 0 B 0 B 0 B 29.63 KB ✅ lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click) 9.88 KB 0 B 0 B 0 B 9.89 KB ✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store) 26.09 KB 0 B 0 B 0 B 26.10 KB ✅ stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable) 32.09 KB 0 B 0 B 0 B 32.13 KB ✅ stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec) 11.75 KB 0 B 0 B 0 B 11.76 KB ✅
page: base server components (hydrating + dynamic + frames + sf reference) 33.21 KB 0 B 0 B +19 B 33.20 KB ⚠️ over by 7 B, 1 B minified headroom assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, trace.js 9.02 KB, wire.js 2.78 KB
page: live server components (base + live/GET + action + isPending/latest) 37.47 KB 0 B 0 B +19 B 37.48 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.06 KB, wire.js 2.78 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread) 35.28 KB 0 B 0 B +19 B 35.23 KB ⚠️ over by 49 B, 1 B minified headroom assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.06 KB, wire.js 2.77 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest) 41.31 KB 0 B 0 B +19 B 41.31 KB ⚠️ over by 3 B, 1 B minified headroom eager (counted): web.js 21.93 KB; assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.19 KB, trace.js 9.08 KB, wire.js 2.77 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate) 40.67 KB 0 B 0 B +19 B 40.72 KB ✅ assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.02 KB, serverForms.js 3.59 KB, trace.js 9.13 KB, wire.js 2.77 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate) 46.87 KB 0 B 0 B +19 B 46.91 KB ✅ eager (counted): client.js 27.07 KB; assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.02 KB, serverForms.js 3.30 KB, trace.js 9.06 KB, wire.js 2.80 KB
server: floor (getRequestEvent + isServer) 1.33 KB 0 B 0 B 0 B 1.34 KB ✅
server: renderToString (the server-render floor) 20.62 KB 0 B 0 B −30 B 20.59 KB ⚠️ over by 31 B, 50 B minified headroom

⚠️ Over the brotli cap within the minified allowance (passes)

  • page: base server components (hydrating + dynamic + frames + sf reference): over brotli cap by 7 B; minified 101,463 B vs 101,444 B recorded with the cap (+19 B) — 1 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread): over brotli cap by 49 B; minified 107,804 B vs 107,785 B recorded with the cap (+19 B) — 1 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • page: compiled live server components (the compiled base page + live/GET + action + isPending/latest): over brotli cap by 3 B; minified 122,986 B vs 122,967 B recorded with the cap (+19 B) — 1 B of the 20 B minified allowance left; +0 B minified over this PR's base
  • server: renderToString (the server-render floor): over brotli cap by 31 B; minified 72,124 B vs 72,154 B recorded with the cap (−30 B) — 50 B of the 20 B minified allowance left; +0 B minified over this PR's base

Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 39471629069

Coverage remained the same at 77.555%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1347
Covered Lines: 1103
Line Coverage: 81.89%
Relevant Branches: 1050
Covered Branches: 756
Branch Coverage: 72.0%
Branches in Coverage %: Yes
Coverage Strength: 27.43 hits per line

💛 - Coveralls

@codspeed

codspeed Bot commented Oct 20, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 39.17%

⚠️ 2 benchmarks spent significant time in system calls

System calls cannot be consistently instrumented, so they are not included in the measure, which understates the real cost. Please switch to the Walltime instrument to accurately measure system calls.

Measurement and system calls

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 195 untouched benchmarks
⏩ 5 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ projection derive: write one NESTED field (reference) 895.2 µs 1,471.5 µs -39.17%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing claude/project-thread-257vck (8d1e950) with next (5a4b2e8)2

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on next (7f8ab2d) during the generation of this report, so 5a4b2e8 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Copy link
Copy Markdown
Member Author

CodSpeed flagged a regression in projection derive: write one NESTED field (reference) (895 µs to 1,471 µs). This PR didn't cause it. The diff only touches examples/*, pnpm-lock.yaml (the router pin for the examples) and a JSDoc comment in packages/web/src/response.ts. None of that is code the packages/signals store benchmarks run. CodSpeed's own report also warns that the comparison crossed runtime environments and used an unexpected base. The other 195 benchmarks didn't change. No fix is needed, and I'm not re-running the check.


Generated by Claude Code

@ryansolid
ryansolid merged commit 1bb070d into next Oct 20, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants