chore: #4183's changeset and re-record the compiled CSR size cap by ryansolid · Pull Request #4209 · solidjs/solid

ryansolid · 2026-10-21T19:38:49Z

Summary

Before: #4183's CHEATSHEET and docs changes ship in the solid-js package but merged without a changeset. Separately, next's Size check has been red since #4176: #4188, #4207 and #4176 each passed alone, but together they put "app: compiled CSR" at 81,159 B minified against 81,138 recorded, 1 B past the 20 B allowance.

After:

A solid-js patch changeset covers docs: fix the from() migration snippet, add createDeferred to the cheatsheet, note SETTLED_CLEANUP_UNOWNED throws #4183.
The compiled CSR cap is re-recorded (26.11 → 26.14 KB, recorded minified 81,138 → 81,159 B), accepted by the maintainer. It is not a frozen floor.

This PR first also carried a fix for lazy nodes stranded when a cleanup throws during #4176's deferred-release window. That fix cost about 35 B minified in every signals scenario, so it's held for a size decision and has been reverted here.

How did you test this change?

There are no runtime code changes. Size CI on this PR checks the re-recorded cap against the merged next.

https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

Generated by Claude Code

#4176 restores the release collector when a cleanup throws while an unfinished pass's frame is dismantled, but the throw also skips the drain at the end of the pass, so lazy nodes the frame's children released before the throw were never released. Drain them before rethrowing. Also adds the solid-js changeset for #4183's docs, which ship in the package. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

changeset-bot · 2026-10-21T19:39:01Z

🦋 Changeset detected

Latest commit: 08b39f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages

Name	Type
solid-js	Patch
@solidjs/diagnostics	Patch
@solidjs/element	Patch
@solidjs/h	Patch
@solidjs/html	Patch
test-integration	Patch
@solidjs/universal	Patch
@solidjs/web	Patch
board-example	Patch
server-dbmon-example	Patch
todos-server-example	Patch
@solidjs/babel-plugin	Patch
@solidjs/compiler	Patch
@solidjs/signals	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2026-10-21T19:43:44Z

Size (brotli, eager entry chunk)

scenario	head	minified vs recorded	cap		lazy chunks (not counted)
signals: core floor (createSignal/Memo/Effect/Root/flush)	7.36 KB	+21 B	7.39 KB	✅
signals: + createStore	14.94 KB	+21 B	14.95 KB	✅
signals: + isPending/latest	10.19 KB	+39 B	10.19 KB	✅
signals: + until/refresh (truth readers, no optimism)	7.97 KB	+21 B	7.98 KB	✅
app: render + one signal (the simple-app floor)	9.67 KB	+21 B	9.70 KB	✅
app: hydrating (no stores) with Show/For/Loading/Errored/lazy	18.33 KB	+21 B	18.36 KB	✅	lazy-page.js 0.04 KB
app: hydrating + every store primitive family	30.38 KB	+39 B	30.41 KB	✅	lazy-page.js 0.04 KB
app: CSR with Show/For/Loading/Errored/lazy	13.24 KB	+21 B	13.28 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier (same app on the `observe` artifacts)	15.02 KB	+21 B	15.04 KB	✅	lazy-page.js 0.04 KB
app: CSR, observe tier + attribution engine enabled	29.62 KB	+21 B	29.63 KB	✅	lazy-page.js 0.04 KB
app: compiled floor (one template, one text hole, one delegated click)	9.88 KB	+21 B	9.89 KB	✅
app: compiled CSR (JSX todo app: spread/merge/omit, events, class/style, keyed For, Show, Loading + lazy, store)	26.12 KB	0 B	26.14 KB	✅	stats.js 0.18 KB
app: compiled hydrating (the same JSX todo app through hydrate(), compiled hydratable)	32.09 KB	+21 B	32.20 KB	✅	stats.js 0.20 KB
frames: eager client consumer (frames client + transport, lazy codec)	11.75 KB	0 B	11.76 KB	✅
page: base server components (hydrating + dynamic + frames + sf reference)	33.17 KB	−8 B	33.20 KB	✅	assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, trace.js 9.02 KB, wire.js 2.78 KB
page: live server components (base + live/GET + action + isPending/latest)	37.47 KB	−130 B	37.53 KB	✅	assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, trace.js 9.06 KB, wire.js 2.78 KB
page: compiled base server components (the base page as JSX: templates with class/style/attributes/events, For/Show; no spread)	35.22 KB	−8 B	35.30 KB	✅	assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.20 KB, trace.js 9.06 KB, wire.js 2.77 KB
page: compiled live server components (the compiled base page + live/GET + action + isPending/latest)	41.34 KB	−130 B	41.42 KB	✅	eager (counted): web.js 22.02 KB; assets.js 0.78 KB, decode.js 6.25 KB, regions.js 1.06 KB, sc-comments.js 0.19 KB, trace.js 9.08 KB, wire.js 2.77 KB
page: base + router (base page + @solidjs/router: createRouter, two routes, preload, useNavigate)	40.67 KB	−8 B	40.72 KB	✅	assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.06 KB, server.js 1.02 KB, serverForms.js 3.59 KB, trace.js 9.13 KB, wire.js 2.77 KB
page: live + router (live page + @solidjs/router: createRouter, two routes, preload, useNavigate)	46.91 KB	−130 B	46.91 KB	✅	eager (counted): client.js 27.10 KB; assets.js 0.78 KB, decode.js 6.25 KB, lazy-page.js 0.04 KB, regions.js 1.07 KB, server.js 1.02 KB, serverForms.js 3.30 KB, trace.js 9.06 KB, wire.js 2.80 KB
server: floor (getRequestEvent + isServer)	1.33 KB	0 B	1.34 KB	✅
server: renderToString (the server-render floor)	20.62 KB	−30 B	20.59 KB	⚠️ over by 31 B, 50 B minified headroom

⚠️ Over the brotli cap within the minified allowance (passes)

server: renderToString (the server-render floor): over brotli cap by 31 B; minified 72,124 B vs 72,154 B recorded with the cap (−30 B) — 50 B of the 20 B minified allowance left; +0 B minified over this PR's base

_{Bundled with Rolldown (what Vite ships), brotli q11, decimal KB. A scenario fails only when it is over its brotli cap and its minified size is more than 20 B over the minified recorded with the cap; over the cap within that allowance is brotli layout noise and passes with a warning. Caps and their recorded minified in scripts/size/scenarios.js; the floor and page caps in floor-caps.json are frozen (lower only, or Size-Exception: in the PR body). npm run ratchet lowers caps per RC; it never raises one (scripts/size/README.md).}

coveralls · 2026-10-21T19:47:33Z

Coverage Report for CI Build 39667947817

Coverage remained the same at 77.662%

Details

Coverage remained the same as the base build.
Patch coverage: No coverable lines changed in this PR.
No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats


Relevant Lines:	1349
Covered Lines:	1105
Line Coverage:	81.91%
Relevant Branches:	1055
Covered Branches:	762
Branch Coverage:	72.23%
Branches in Coverage %:	Yes
Coverage Strength:	27.65 hits per line

💛 - Coveralls

The drain costs about 35 B minified in every signals scenario, including the simple-app floor, for a leak that only follows a cleanup that throws. Held for a size decision. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

ryansolid · 2026-10-21T19:52:50Z

The check (Size) failure isn't this PR's: the PR is changeset-only and is 0 B against its base on every scenario. next itself is red since #4176. #4188, #4207 and #4176 each passed alone, but together they put "app: compiled CSR" at 81,159 B minified against 81,138 recorded, 1 B past the 20 B allowance. The fix is a re-record of that cap (26.11 → 26.14 KB, recorded minified 81,138 → 81,159 B). It's waiting on the maintainer's OK, and once approved it lands in this PR.

— Claude via Claude Code

Generated by Claude Code

codspeed · 2026-10-21T19:58:04Z

Merging this PR will not alter performance

1 warning

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 196 untouched benchmarks
⏩ 5 skipped benchmarks¹

_{Comparing fix/deferred-release-drain (08b39f4) with next (0222d68)}

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

…drain

Each passed alone; together they put next 1 B past the 20 B minified allowance (81,159 B against 81,138 recorded). Accepted by the maintainer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

ryansolid changed the title ~~fix(signals): release lazy nodes collected before a throwing cleanup~~ chore: add the solid-js changeset for #4183's docs Oct 21, 2026

claude added 2 commits October 21, 2026 20:09

Merge remote-tracking branch 'origin/next' into fix/deferred-release-…

ab6a0c1

…drain

ryansolid changed the title ~~chore: add the solid-js changeset for #4183's docs~~ chore: #4183's changeset and re-record the compiled CSR size cap Oct 21, 2026

ryansolid merged commit a2a5b6f into next Oct 21, 2026
8 checks passed

Navigation Menu

Repository navigation

chore: #4183's changeset and re-record the compiled CSR size cap - #4209

chore: #4183's changeset and re-record the compiled CSR size cap#4209
ryansolid merged 4 commits into
nextfrom
fix/deferred-release-drain

ryansolid commented Oct 21, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

coveralls commented Oct 21, 2026 •

edited

Loading

Uh oh!

ryansolid commented Oct 21, 2026

Uh oh!

codspeed Bot commented Oct 21, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ryansolid commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

How did you test this change?

Uh oh!

changeset-bot Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size (brotli, eager entry chunk)

⚠️ Over the brotli cap within the minified allowance (passes)

Uh oh!

coveralls commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report for CI Build 39667947817

Coverage remained the same at 77.662%

Details

Uncovered Changes

Coverage Regressions

Coverage Stats

💛 - Coveralls

Uh oh!

ryansolid commented Oct 21, 2026

Uh oh!

codspeed Bot commented Oct 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ryansolid commented Oct 21, 2026 •

edited

Loading

changeset-bot Bot commented Oct 21, 2026 •

edited

Loading

github-actions Bot commented Oct 21, 2026 •

edited

Loading

coveralls commented Oct 21, 2026 •

edited

Loading

codspeed Bot commented Oct 21, 2026 •

edited

Loading