Feat/conductor stepper#43
Merged
Merged
Conversation
- Handle 'error' event in spawnPromise to avoid unhandled rejection crashes - Guard renderNode against null/undefined AST nodes - Guard renderFunctionArguments and renderArguments against undefined nodes Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…n-tabs - Add @sourceacademy/common-tabs (ITabService / Tab) — the standard contract for web plugins to register, show and hide side-content tabs. - The web stepper now registers its tab through the injected ITabService (registerTab + showTab) instead of exposing a structural `tab`, and the bundle default-exports a `default(require) => PluginClass` factory; wrap.mjs wraps the CommonJS output so React/Blueprint resolve via the host's require-provider. - Runner and host ship the per-language SyntaxProfile in the steps message, so the language-agnostic host renders each language's surface syntax with no per-language host code. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…ring Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- import conductor types (IChannel/IConduit/IPlugin) as type-only so rollup does not try to resolve them as runtime values - replace this-alias in StepperHostPlugin with captured method locals - drop explicit any in readNodeProp and literal stringification - remove stale react/display-name eslint-disable referencing an undefined rule Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The vitest config does not enable globals, so the stepper test suites must import test/expect explicitly like the other plugin tests do. Without this the suites fail to load with "ReferenceError: test is not defined". Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.