Repository navigation
fix: keep focus on filter textbox when clicking clear button - #2794
Merged
love-linger merged 1 commit intoOct 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Clicking the "×" clear button inside a filter TextBox moves keyboard focus to the button, which then hides itself (IsVisible bound to the filter string). Focus is lost entirely, so the user cannot keep typing and must click the TextBox again.
Fix
Set
Focusable="False"on all clear buttons inTextBox.InnerRightContentso clicking them never steals focus. These buttons are unreachable via keyboard anyway (palettes override Tab navigation, and Delete/Backspace already covers clearing), so this has no accessibility impact.Scope
Same fix applied to all matching buttons across the 9 command palettes (LauncherPages, Repository, Checkout, Compare, Merge, ExecuteCustomAction, FileHistory, OpenFile, Blame) and in-app search boxes (Repository sidebar, WorkingCopy, CommitSearchView, CommitChanges, RevisionFiles, RevisionCompare, SubmoduleRevisionCompare, Compare window, StashesPage, BranchSelector, RepositoryConfigure HTTP proxy field).
Excluded:
Welcome.axaml(its click handler already refocuses the search box) and standalone action buttons that reuseIcons.Clear(stash clear, discard changes, folder pickers, dialog close icons).