Skip to content

docs: add missing Go doc comments #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
valerybugakov wants to merge 1 commit into from
Closed

docs: add missing Go doc comments #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions error.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func NamedError(key string, err error) Field {

type errArray []error

// MarshalLogArray implements zapcore.ArrayMarshaler.
func (errs errArray) MarshalLogArray(arr zapcore.ArrayEncoder) error {
for i := range errs {
if errs[i] == nil {
Expand All @@ -73,6 +74,7 @@ type errArrayElem struct {
error
}

// MarshalLogObject implements zapcore.ObjectMarshaler.
func (e *errArrayElem) MarshalLogObject(enc zapcore.ObjectEncoder) error {
// Re-use the error field's logic, which supports non-standard error types.
Error(e.error).AddTo(enc)
Expand Down
2 changes: 2 additions & 0 deletions sugar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,7 @@ type invalidPair struct {
key, value interface{}
}

// MarshalLogObject implements zapcore.ObjectMarshaler.
func (p invalidPair) MarshalLogObject(enc zapcore.ObjectEncoder) error {
enc.AddInt64("position", int64(p.position))
Any("key", p.key).AddTo(enc)
Expand All @@ -295,6 +296,7 @@ func (p invalidPair) MarshalLogObject(enc zapcore.ObjectEncoder) error {

type invalidPairs []invalidPair

// MarshalLogArray implements zapcore.ArrayMarshaler.
func (ps invalidPairs) MarshalLogArray(enc zapcore.ArrayEncoder) error {
var err error
for i := range ps {
Expand Down
Loading