Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a08b56-33b1-72da-87f9-e1fe07506a77 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a08b56-33b1-72da-87f9-e1fe07506a77 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacks on #47, which first upgrades both Google providers to the final 6.x release.
This upgrades
hashicorp/googleandhashicorp/google-betafrom 6.50.0 to 7.31.0 and regenerates their CDKTF Go bindings. Version 7.31 includes the fix for the spurioustimeoutsdiff regression introduced alongside v7 identity support.Rollout considerations
This PR only publishes generated bindings. After merge,
sourcegraph/sourcegraphmust update its generated-module dependencies and publish ansg mspbuild. The managed-services category lockfiles should then be upgraded and regenerated progressively: test, internal, then external.Google provider v7 includes behavior changes that need review during live plans:
google_project_service.disable_on_destroyno longer retains the old implicittruebehavior when unset.No live Terraform plans or applies were run as part of this bindings PR.
Test plan
go test ./dev/managedservicesplatform/...insourcegraph/sourcegraphagainst the local 7.31 modules.managed-servicesusing ansg mspbinary built against the local 7.31 modules.init -backend=falseandvalidatefor all fivemsp-testbed/robertstacks and representative external Cloud Run stacks fromenterprise-portal/prodandreleaseworker/prod.