remove/batches: Remove batch exec command - #1381
Merged
Merged
Conversation
Server-side Batch Changes execution now uses the batch-exec binary in the Sourcegraph monorepo, so src-cli no longer needs its internal executor entrypoint. Remove the command, its executor-only workspace implementation and vendored execution-input model, and update the generated documentation inventory. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-01a0e79c-fa8d-73d8-bd66-3a3b34315141
burmudar
marked this pull request as ready for review
September 28, 2026 10:59
BolajiOlajide
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server-side Batch Changes execution now runs through the
batch-execbinary in the Sourcegraph monorepo, so retaining the duplicate internalsrc batch execruntime in src-cli leaves an unused execution path to maintain.This removes the command registration and implementation, its executor-only workspace creator, and the vendored workspace-execution input model that had no remaining consumers. Shared Batch Changes execution code used by
batch applyandbatch previewremains unchanged. The generated-document inventory and changelog now reflect the removal.The generated CLI references in
sourcegraph/sourcegraphshould be refreshed after this src-cli change is released.Test plan
go test ./...(cd lib && go test ./...)go run ./cmd/src batch execreturnsunknown subcommand "exec"