Repository navigation
Upgrade Sourcemeta dependencies - #944
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: Upgrade Sourcemeta dependencies to incorporate upstream schema-handling and Core API updates.
🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| for (const auto *keyword : {"type", "extends", "disallow"}) { | ||
| for (const auto &keyword : profile->unique_branches) { |
There was a problem hiding this comment.
Could you check unique() in vendor/blaze/src/canonicalizer/canonicalize.cc:1064 when an anyOf references two separate definitions that both contain {"type":"string"}? Graph deduplication reduces this to a single-branch anyOf after the single-branch rules have run, so the output fails canonical-draft4.json's minItems: 2 constraint and changes again on a second canonicalize() call.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| // act on here. The only null an expanded item compacts to is the one a | ||
| // JSON literal holds, which is data rather than absence, and dropping it | ||
| // would silently lose the literal | ||
| result.push_back(compact(state, active_context, inverse_context, |
There was a problem hiding this comment.
Could you check the null assumption at vendor/core/src/core/jsonld/jsonld_compaction.cc:112: jsonld_is_expanded() accepts property lists containing {"@value":null}, and compact_value() returns null for these without an @json datatype? Such a list now compacts to {"@list":[null]} instead of {"@list":[]}, contrary to the null-elision step quoted above.
Severity: medium
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com