Skip to content

Upgrade Sourcemeta dependencies - #944

Merged
jviotti merged 1 commit into
mainfrom
all-deps-20
Oct 23, 2026
Merged

jviotti merged 1 commit into
mainfrom
all-deps-20

Conversation

@jviotti

@jviotti jviotti commented Oct 23, 2026 •

Copy link
Copy Markdown
Member

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

View guided diff

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 117 files

View guided diff | Re-trigger cubic

@augmentcode

augmentcode Bot commented Oct 23, 2026

Copy link
Copy Markdown
🤖 Augment PR Summary

Summary: Upgrade Sourcemeta dependencies to incorporate upstream schema-handling and Core API updates.

  • Refresh pinned Core and Blaze revisions and vendored sources.
  • Extend Draft 4 canonicalization to a reference-based graph form.
  • Update the canonical Draft 4 meta-schema for graph nodes and edges.
  • Enable more OpenAPI 3.0 transformation and lint rules, with nullable safeguards.
  • Validate pruned OpenAPI subschemas and reject boolean reference targets.
  • Allow definitions containers throughout code generation.
  • Add caller-supplied Markdown and Punycode input bounds.
  • Add a move-enabled MCP result writer and refine MCP validation.
  • Refactor JSON-LD, diff, HTTP, URI, numeric, and platform helpers.

🤖 Was this summary useful? React with 👍 or 👎

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 2 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

}

for (const auto *keyword : {"type", "extends", "disallow"}) {
for (const auto &keyword : profile->unique_branches) {

@augmentcode augmentcode Bot Oct 23, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check unique() in vendor/blaze/src/canonicalizer/canonicalize.cc:1064 when an anyOf references two separate definitions that both contain {"type":"string"}? Graph deduplication reduces this to a single-branch anyOf after the single-branch rules have run, so the output fails canonical-draft4.json's minItems: 2 constraint and changes again on a second canonicalize() call.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

// act on here. The only null an expanded item compacts to is the one a
// JSON literal holds, which is data rather than absence, and dropping it
// would silently lose the literal
result.push_back(compact(state, active_context, inverse_context,

@augmentcode augmentcode Bot Oct 23, 2026 •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the null assumption at vendor/core/src/core/jsonld/jsonld_compaction.cc:112: jsonld_is_expanded() accepts property lists containing {"@value":null}, and compact_value() returns null for these without an @json datatype? Such a list now compacts to {"@list":[null]} instead of {"@list":[]}, contrary to the null-elision step quoted above.

Severity: medium

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.

@jviotti
jviotti merged commit 979aa41 into main Oct 23, 2026
14 checks passed
@jviotti
jviotti deleted the all-deps-20 branch October 23, 2026 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant