Cover legacy JSON Schema applicators and an invalid identifier - #2895
Merged
Merged
Conversation
Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
🤖 Augment PR SummarySummary: This PR expands JSON Schema frame test coverage for legacy applicators and malformed identifiers. Changes:
SchemaKeywordError metadata.
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
You’re at about 92% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/jsonschema/jsonschema_frame_test.cc">
<violation number="1" location="test/jsonschema/jsonschema_frame_test.cc:2076">
P3: This test asserts only that a frame location exists at the `requires` pointer, which any value-applicator classification (in-place or parent-traversal) would satisfy, so it does not verify the parent-instance behavior its name claims. Either strengthen the assertion (e.g., check the returned Location's `instances` or parent relationship) or rename the test to reflect that it only covers value-as-subschema framing.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| } | ||
| } | ||
|
|
||
| TEST(draft2_requires_applies_to_the_parent_instance) { |
There was a problem hiding this comment.
P3: This test asserts only that a frame location exists at the requires pointer, which any value-applicator classification (in-place or parent-traversal) would satisfy, so it does not verify the parent-instance behavior its name claims. Either strengthen the assertion (e.g., check the returned Location's instances or parent relationship) or rename the test to reflect that it only covers value-as-subschema framing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At test/jsonschema/jsonschema_frame_test.cc, line 2076:
<comment>This test asserts only that a frame location exists at the `requires` pointer, which any value-applicator classification (in-place or parent-traversal) would satisfy, so it does not verify the parent-instance behavior its name claims. Either strengthen the assertion (e.g., check the returned Location's `instances` or parent relationship) or rename the test to reflect that it only covers value-as-subschema framing.</comment>
<file context>
@@ -2072,3 +2072,35 @@ TEST(accessors_metaschema_unresolvable) {
}
}
+
+TEST(draft2_requires_applies_to_the_parent_instance) {
+ const sourcemeta::core::JSON document = sourcemeta::core::parse_json(R"JSON({
+ "$schema": "http://json-schema.org/draft-02/schema#",
</file context>
Benchmark
|
| Benchmark | main |
This branch | Change |
|---|---|---|---|
JSON_String_Equal_100 |
6.55 ns | 7.47 ns | +14.2% |
JSON_Parse_Object_Object_Properties |
5.48 us | 5.20 us | -5.2% |
JSON_Object_Defines_Miss_Too_Small |
2.76 ns | 2.59 ns | -6.2% |
All 103 benchmarks
| Benchmark | main |
This branch | Change |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.18 ns | 2.18 ns | -0.0% |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.18 ns | 2.18 ns | -0.0% |
Regex_Period_Asterisk |
2.18 ns | 2.18 ns | -0.1% |
Regex_Group_Period_Asterisk_Group |
2.18 ns | 2.18 ns | -0.0% |
Regex_Period_Plus |
2.80 ns | 2.80 ns | +0.0% |
Regex_Period |
2.80 ns | 2.80 ns | -0.0% |
Regex_Caret_Period_Plus_Dollar |
3.11 ns | 3.11 ns | -0.0% |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.12 ns | 3.11 ns | -0.2% |
Regex_Caret_Period_Asterisk_Dollar |
3.11 ns | 3.11 ns | -0.0% |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
3.11 ns | 3.11 ns | +0.1% |
Regex_Caret_X_Hyphen |
6.85 ns | 6.85 ns | -0.1% |
Regex_Period_Md_Dollar |
27.68 ns | 27.87 ns | +0.7% |
Regex_Caret_Slash_Period_Asterisk |
6.84 ns | 6.84 ns | +0.0% |
Regex_Caret_Period_Range_Dollar |
3.74 ns | 3.73 ns | -0.1% |
Regex_Nested_Backtrack |
38.84 ns | 38.81 ns | -0.1% |
JSON_Array_Of_Objects_Unique |
401.77 ns | 399.05 ns | -0.7% |
JSON_Parse_1 |
4.52 us | 4.47 us | -1.1% |
JSON_Parse_Real |
4.94 us | 5.04 us | +2.0% |
JSON_Parse_Decimal |
7.25 us | 7.27 us | +0.3% |
JSON_Parse_Schema_ISO_Language |
3.31 ms | 3.27 ms | -1.4% |
JSON_Parse_Integer |
3.62 us | 3.72 us | +2.9% |
JSON_Parse_String_NonSSO_Plain |
3.10 us | 3.06 us | -1.4% |
JSON_Parse_String_SSO_Plain |
2.68 us | 2.64 us | -1.4% |
JSON_Parse_String_Escape_Heavy |
12.01 us | 11.87 us | -1.2% |
JSON_Parse_Object_Short_Keys |
7.52 us | 7.79 us | +3.6% |
JSON_Parse_Object_Scalar_Properties |
3.84 us | 3.98 us | +3.7% |
JSON_Parse_Object_Array_Properties |
5.46 us | 5.25 us | -3.9% |
JSON_Parse_Object_Object_Properties |
5.48 us | 5.20 us | -5.2% |
JSON_Parse_Nested_Containers |
34.40 us | 34.07 us | -1.0% |
JSON_Fast_Hash_Helm_Chart_Lock |
61.03 ns | 61.02 ns | -0.0% |
JSON_Equality_Helm_Chart_Lock |
148.35 ns | 154.87 ns | +4.4% |
JSON_String_Equal_10 |
6.85 ns | 6.85 ns | +0.1% |
JSON_String_Equal_100 |
6.55 ns | 7.47 ns | +14.2% |
JSON_String_Equal_Small_By_Perfect_Hash_10 |
0.94 ns | 0.94 ns | -0.0% |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 |
10.58 ns | 10.58 ns | -0.0% |
JSON_String_Fast_Hash_10 |
2.49 ns | 2.49 ns | +0.0% |
JSON_String_Fast_Hash_100 |
2.49 ns | 2.49 ns | -0.0% |
JSON_String_Key_Hash_10 |
2.49 ns | 2.49 ns | -0.2% |
JSON_String_Key_Hash_100 |
6.54 ns | 6.53 ns | -0.0% |
JSON_Object_Defines_Miss_Same_Length |
2.82 ns | 2.81 ns | -0.5% |
JSON_Object_Defines_Miss_Too_Small |
2.76 ns | 2.59 ns | -6.2% |
JSON_Object_Defines_Miss_Too_Large |
3.42 ns | 3.42 ns | +0.0% |
JSON_From_String_Copy |
11.25 ns | 11.03 ns | -1.9% |
JSON_From_String_Temporary |
9.95 ns | 9.94 ns | -0.1% |
JSON_Number_To_Double |
22.78 ns | 22.81 ns | +0.2% |
JSON_Object_At_Last_Key_8 |
3.80 ns | 3.82 ns | +0.5% |
JSON_Object_At_Last_Key_32 |
12.17 ns | 12.18 ns | +0.1% |
JSON_Object_At_Last_Key_128 |
49.06 ns | 49.07 ns | +0.0% |
JSON_Object_At_Last_Key_512 |
396.96 ns | 396.61 ns | -0.1% |
JSON_Divisible_By_Decimal |
239.20 ns | 249.02 ns | +4.1% |
JSON_PropertySet_Contains |
50.82 ns | 50.87 ns | +0.1% |
JSON_PropertySet_Filter_Object_Properties |
39.86 ns | 40.44 ns | +1.4% |
JSON_PropertySet_Insert |
574.32 ns | 546.93 ns | -4.8% |
Pointer_Object_Traverse |
28.67 ns | 28.62 ns | -0.2% |
Pointer_Object_Try_Traverse |
30.19 ns | 30.20 ns | +0.0% |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
145.89 ns | 148.61 ns | +1.9% |
Pointer_Walker_Schema_ISO_Language |
1.54 ms | 1.53 ms | -0.8% |
Pointer_Untracked_Deeply_Nested |
1.25 ms | 1.24 ms | -0.9% |
Pointer_Tracked_Deeply_Nested |
1.59 ms | 1.60 ms | +0.6% |
Pointer_Position_Tracker_Get_Deeply_Nested |
611.14 ns | 606.82 ns | -0.7% |
Schema_Tracker_ISO_Language |
4.37 ms | 4.31 ms | -1.5% |
Schema_Tracker_ISO_Language_To_JSON |
16.39 ms | 16.34 ms | -0.3% |
Schema_Frame_WoT_References |
2.20 ms | 2.21 ms | +0.4% |
Schema_Frame_OMC_References |
9.75 ms | 9.70 ms | -0.5% |
Schema_Frame_OMC_Pointers |
19.19 ms | 18.49 ms | -3.6% |
Schema_Frame_OMC_Locations |
8.36 ms | 8.35 ms | -0.1% |
Schema_Frame_ISO_Language_Locations |
42.66 ms | 42.79 ms | +0.3% |
Schema_Frame_ISO_Language_Root |
294.20 ns | 293.89 ns | -0.1% |
Schema_Frame_KrakenD_References |
15.50 ms | 15.72 ms | +1.4% |
Schema_Frame_KrakenD_Reachable |
153.18 ms | 155.80 ms | +1.7% |
Schema_Frame_ISO_Language_Locations_To_JSON |
31.10 ms | 30.99 ms | -0.4% |
Schema_Frame_Many_Resources_References |
136.26 ms | 136.65 ms | +0.3% |
Schema_Frame_Deeply_Nested_References |
11.25 ms | 11.08 ms | -1.5% |
Schema_Format_ISO_Language |
48.41 ms | 48.97 ms | +1.2% |
Schema_Bundle_Meta_2020_12 |
616.54 us | 614.89 us | -0.3% |
Schema_Bundle_Many_Remotes_With_Fragments |
6.82 ms | 6.83 ms | +0.2% |
OpenAPI_Format_Synthetic_3_1 |
45.86 ms | 46.99 ms | +2.5% |
JSONPath_Descendant_Filter_Nested |
1.52 us | 1.54 us | +0.7% |
URITemplateRouter_Create |
23.38 us | 22.95 us | -1.9% |
URITemplateRouter_Match |
177.67 ns | 175.93 ns | -1.0% |
URITemplateRouterView_Restore |
8.48 us | 8.42 us | -0.7% |
URITemplateRouterView_Match |
163.94 ns | 164.09 ns | +0.1% |
URITemplateRouterView_Arguments |
431.10 ns | 430.91 ns | -0.0% |
URITemplateRouter_Match_BasePath |
209.54 ns | 209.67 ns | +0.1% |
URITemplateRouterView_Match_BasePath |
184.62 ns | 186.03 ns | +0.8% |
JSONL_Parse_Large |
9.17 ms | 9.14 ms | -0.4% |
JSONL_Parse_Large_GZIP |
9.33 ms | 9.34 ms | +0.1% |
JSONLD_Catalog_Annotation_List_Populate |
596.49 us | 602.07 us | +0.9% |
JSONLD_Catalog_Materialize |
3.57 ms | 3.62 ms | +1.2% |
HTML_Build_Table_100000 |
37.83 ms | 38.26 ms | +1.1% |
HTML_Render_Table_100000 |
1.85 ms | 1.89 ms | +2.2% |
Markdown_To_HTML_Realistic_Document |
4.15 ms | 4.13 ms | -0.5% |
Markdown_To_HTML_Pathological |
12.91 ms | 12.99 ms | +0.6% |
Markdown_To_HTML_Short_Descriptions |
565.82 ns | 568.66 ns | +0.5% |
GZIP_Compress_ISO_Language_Set_3_Locations |
37.48 ms | 37.71 ms | +0.6% |
GZIP_Decompress_ISO_Language_Set_3_Locations |
5.16 ms | 5.12 ms | -0.7% |
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations |
7.08 ms | 7.07 ms | -0.2% |
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations |
9.14 ms | 9.12 ms | -0.2% |
GZIP_Compress_ISO_Language_Set_3_Schema |
2.23 ms | 2.25 ms | +0.8% |
GZIP_Decompress_ISO_Language_Set_3_Schema |
420.14 us | 419.87 us | -0.1% |
JOSE_VerifySignature_RS256 |
47.04 us | 47.40 us | +0.8% |
JOSE_VerifySignature_ES512 |
1.73 ms | 1.73 ms | -0.1% |
Crypto_CRC32_Large_JSONL |
101.88 us | 101.76 us | -0.1% |
Benchmark
|
| Benchmark | main |
This branch | Change |
|---|---|---|---|
JSON_String_Key_Hash_100 |
7.30 ns | 7.84 ns | +7.4% |
JSON_Object_Defines_Miss_Too_Large |
3.61 ns | 3.81 ns | +5.6% |
JSON_Object_At_Last_Key_32 |
23.37 ns | 22.13 ns | -5.3% |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 |
9.58 ns | 8.98 ns | -6.4% |
Regex_Caret_X_Hyphen |
6.50 ns | 6.04 ns | -7.1% |
JSON_PropertySet_Insert |
1.23 us | 977.88 ns | -20.6% |
All 103 benchmarks
| Benchmark | main |
This branch | Change |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
2.41 ns | 2.33 ns | -3.3% |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.47 ns | 2.43 ns | -1.7% |
Regex_Period_Asterisk |
2.48 ns | 2.43 ns | -1.9% |
Regex_Group_Period_Asterisk_Group |
2.46 ns | 2.42 ns | -1.9% |
Regex_Period_Plus |
2.53 ns | 2.48 ns | -1.9% |
Regex_Period |
2.43 ns | 2.33 ns | -4.1% |
Regex_Caret_Period_Plus_Dollar |
2.51 ns | 2.48 ns | -1.4% |
Regex_Caret_Group_Period_Plus_Group_Dollar |
2.38 ns | 2.32 ns | -2.3% |
Regex_Caret_Period_Asterisk_Dollar |
2.40 ns | 2.33 ns | -3.1% |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.48 ns | 2.43 ns | -1.9% |
Regex_Caret_X_Hyphen |
6.50 ns | 6.04 ns | -7.1% |
Regex_Period_Md_Dollar |
27.55 ns | 26.31 ns | -4.5% |
Regex_Caret_Slash_Period_Asterisk |
5.86 ns | 5.86 ns | +0.0% |
Regex_Caret_Period_Range_Dollar |
2.78 ns | 2.71 ns | -2.6% |
Regex_Nested_Backtrack |
38.17 ns | 36.63 ns | -4.0% |
JSON_Array_Of_Objects_Unique |
514.28 ns | 496.00 ns | -3.6% |
JSON_Parse_1 |
6.57 us | 6.49 us | -1.3% |
JSON_Parse_Real |
11.18 us | 10.79 us | -3.5% |
JSON_Parse_Decimal |
8.51 us | 8.48 us | -0.3% |
JSON_Parse_Schema_ISO_Language |
7.53 ms | 7.30 ms | -3.0% |
JSON_Parse_Integer |
4.17 us | 4.11 us | -1.6% |
JSON_Parse_String_NonSSO_Plain |
6.11 us | 5.83 us | -4.5% |
JSON_Parse_String_SSO_Plain |
2.62 us | 2.56 us | -2.1% |
JSON_Parse_String_Escape_Heavy |
21.72 us | 21.09 us | -2.9% |
JSON_Parse_Object_Short_Keys |
9.38 us | 9.10 us | -3.0% |
JSON_Parse_Object_Scalar_Properties |
4.72 us | 4.67 us | -1.0% |
JSON_Parse_Object_Array_Properties |
8.53 us | 8.46 us | -0.9% |
JSON_Parse_Object_Object_Properties |
8.47 us | 8.52 us | +0.5% |
JSON_Parse_Nested_Containers |
58.87 us | 59.53 us | +1.1% |
JSON_Fast_Hash_Helm_Chart_Lock |
80.63 ns | 81.68 ns | +1.3% |
JSON_Equality_Helm_Chart_Lock |
202.70 ns | 202.83 ns | +0.1% |
JSON_String_Equal_10 |
9.81 ns | 9.81 ns | -0.0% |
JSON_String_Equal_100 |
11.81 ns | 11.84 ns | +0.2% |
JSON_String_Equal_Small_By_Perfect_Hash_10 |
1.27 ns | 1.26 ns | -0.4% |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 |
9.58 ns | 8.98 ns | -6.4% |
JSON_String_Fast_Hash_10 |
3.78 ns | 3.79 ns | +0.3% |
JSON_String_Fast_Hash_100 |
3.78 ns | 3.82 ns | +0.9% |
JSON_String_Key_Hash_10 |
2.90 ns | 2.90 ns | +0.1% |
JSON_String_Key_Hash_100 |
7.30 ns | 7.84 ns | +7.4% |
JSON_Object_Defines_Miss_Same_Length |
3.48 ns | 3.44 ns | -1.2% |
JSON_Object_Defines_Miss_Too_Small |
4.12 ns | 4.07 ns | -1.2% |
JSON_Object_Defines_Miss_Too_Large |
3.61 ns | 3.81 ns | +5.6% |
JSON_From_String_Copy |
45.42 ns | 46.81 ns | +3.0% |
JSON_From_String_Temporary |
51.35 ns | 52.60 ns | +2.4% |
JSON_Number_To_Double |
78.35 ns | 78.85 ns | +0.6% |
JSON_Object_At_Last_Key_8 |
7.41 ns | 7.45 ns | +0.5% |
JSON_Object_At_Last_Key_32 |
23.37 ns | 22.13 ns | -5.3% |
JSON_Object_At_Last_Key_128 |
83.74 ns | 83.33 ns | -0.5% |
JSON_Object_At_Last_Key_512 |
325.70 ns | 319.47 ns | -1.9% |
JSON_Divisible_By_Decimal |
240.16 ns | 240.36 ns | +0.1% |
JSON_PropertySet_Contains |
76.04 ns | 76.60 ns | +0.7% |
JSON_PropertySet_Filter_Object_Properties |
48.46 ns | 48.39 ns | -0.2% |
JSON_PropertySet_Insert |
1.23 us | 977.88 ns | -20.6% |
Pointer_Object_Traverse |
37.17 ns | 36.89 ns | -0.8% |
Pointer_Object_Try_Traverse |
39.53 ns | 39.63 ns | +0.2% |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
142.28 ns | 137.49 ns | -3.4% |
Pointer_Walker_Schema_ISO_Language |
9.97 ms | 9.90 ms | -0.7% |
Pointer_Untracked_Deeply_Nested |
2.07 ms | 2.09 ms | +1.1% |
Pointer_Tracked_Deeply_Nested |
3.68 ms | 3.63 ms | -1.3% |
Pointer_Position_Tracker_Get_Deeply_Nested |
548.03 ns | 565.71 ns | +3.2% |
Schema_Tracker_ISO_Language |
10.19 ms | 10.54 ms | +3.5% |
Schema_Tracker_ISO_Language_To_JSON |
49.40 ms | 48.94 ms | -0.9% |
Schema_Frame_WoT_References |
4.59 ms | 4.46 ms | -2.9% |
Schema_Frame_OMC_References |
20.06 ms | 19.23 ms | -4.1% |
Schema_Frame_OMC_Pointers |
36.43 ms | 35.00 ms | -3.9% |
Schema_Frame_OMC_Locations |
17.07 ms | 16.38 ms | -4.0% |
Schema_Frame_ISO_Language_Locations |
61.34 ms | 60.26 ms | -1.8% |
Schema_Frame_ISO_Language_Root |
1.63 us | 1.61 us | -1.2% |
Schema_Frame_KrakenD_References |
32.08 ms | 31.43 ms | -2.0% |
Schema_Frame_KrakenD_Reachable |
211.98 ms | 205.32 ms | -3.1% |
Schema_Frame_ISO_Language_Locations_To_JSON |
135.44 ms | 136.91 ms | +1.1% |
Schema_Frame_Many_Resources_References |
447.28 ms | 440.55 ms | -1.5% |
Schema_Frame_Deeply_Nested_References |
16.65 ms | 17.40 ms | +4.5% |
Schema_Format_ISO_Language |
64.75 ms | 63.58 ms | -1.8% |
Schema_Bundle_Meta_2020_12 |
1.24 ms | 1.21 ms | -3.0% |
Schema_Bundle_Many_Remotes_With_Fragments |
21.40 ms | 20.96 ms | -2.1% |
OpenAPI_Format_Synthetic_3_1 |
85.13 ms | 82.69 ms | -2.9% |
JSONPath_Descendant_Filter_Nested |
1.64 us | 1.62 us | -1.3% |
URITemplateRouter_Create |
33.30 us | 32.05 us | -3.7% |
URITemplateRouter_Match |
236.66 ns | 229.63 ns | -3.0% |
URITemplateRouterView_Restore |
16.50 us | 17.00 us | +3.0% |
URITemplateRouterView_Match |
167.94 ns | 170.78 ns | +1.7% |
URITemplateRouterView_Arguments |
409.40 ns | 410.92 ns | +0.4% |
URITemplateRouter_Match_BasePath |
261.32 ns | 262.38 ns | +0.4% |
URITemplateRouterView_Match_BasePath |
194.09 ns | 194.11 ns | +0.0% |
JSONL_Parse_Large |
22.75 ms | 22.66 ms | -0.4% |
JSONL_Parse_Large_GZIP |
21.75 ms | 21.63 ms | -0.5% |
JSONLD_Catalog_Annotation_List_Populate |
2.57 ms | 2.57 ms | +0.1% |
JSONLD_Catalog_Materialize |
6.06 ms | 6.06 ms | -0.1% |
HTML_Build_Table_100000 |
77.28 ms | 77.83 ms | +0.7% |
HTML_Render_Table_100000 |
11.87 ms | 11.83 ms | -0.3% |
Markdown_To_HTML_Realistic_Document |
4.25 ms | 4.25 ms | +0.0% |
Markdown_To_HTML_Pathological |
15.01 ms | 15.10 ms | +0.6% |
Markdown_To_HTML_Short_Descriptions |
533.27 ns | 531.99 ns | -0.2% |
GZIP_Compress_ISO_Language_Set_3_Locations |
28.86 ms | 29.14 ms | +1.0% |
GZIP_Decompress_ISO_Language_Set_3_Locations |
10.78 ms | 10.67 ms | -1.0% |
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations |
12.33 ms | 12.03 ms | -2.4% |
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations |
17.08 ms | 17.09 ms | +0.1% |
GZIP_Compress_ISO_Language_Set_3_Schema |
2.01 ms | 2.01 ms | +0.0% |
GZIP_Decompress_ISO_Language_Set_3_Schema |
639.65 us | 638.63 us | -0.2% |
JOSE_VerifySignature_RS256 |
17.69 us | 17.63 us | -0.4% |
JOSE_VerifySignature_ES512 |
944.93 us | 944.51 us | -0.0% |
Crypto_CRC32_Large_JSONL |
47.63 us | 47.37 us | -0.5% |
Benchmark
|
| Benchmark | main |
This branch | Change |
|---|---|---|---|
JSON_Parse_Object_Scalar_Properties |
3.48 us | 4.49 us | +29.0% |
JSON_Parse_Object_Short_Keys |
6.91 us | 8.87 us | +28.4% |
JSON_Parse_Object_Array_Properties |
5.37 us | 6.66 us | +24.0% |
JSONL_Parse_Large_GZIP |
7.61 ms | 9.25 ms | +21.6% |
Markdown_To_HTML_Realistic_Document |
3.98 ms | 4.82 ms | +21.2% |
JSONL_Parse_Large |
7.49 ms | 9.06 ms | +21.0% |
JSON_Parse_Object_Object_Properties |
5.36 us | 6.41 us | +19.5% |
JSON_Parse_Schema_ISO_Language |
2.85 ms | 3.34 ms | +17.4% |
Pointer_Untracked_Deeply_Nested |
982.03 us | 1.13 ms | +15.0% |
Markdown_To_HTML_Short_Descriptions |
470.57 ns | 536.33 ns | +14.0% |
Schema_Tracker_ISO_Language |
3.80 ms | 4.29 ms | +12.9% |
Schema_Frame_ISO_Language_Locations_To_JSON |
26.64 ms | 30.03 ms | +12.7% |
Pointer_Tracked_Deeply_Nested |
1.36 ms | 1.54 ms | +12.6% |
Schema_Frame_KrakenD_References |
12.73 ms | 14.30 ms | +12.4% |
Regex_Caret_Slash_Period_Asterisk |
5.66 ns | 6.20 ns | +9.6% |
JSON_Parse_1 |
3.98 us | 4.33 us | +8.8% |
HTML_Build_Table_100000 |
29.24 ms | 31.66 ms | +8.3% |
Schema_Tracker_ISO_Language_To_JSON |
11.72 ms | 12.69 ms | +8.3% |
Schema_Frame_KrakenD_Reachable |
101.56 ms | 109.64 ms | +8.0% |
Schema_Bundle_Meta_2020_12 |
468.81 us | 503.76 us | +7.5% |
OpenAPI_Format_Synthetic_3_1 |
35.38 ms | 37.44 ms | +5.8% |
Schema_Format_ISO_Language |
35.05 ms | 36.99 ms | +5.5% |
Schema_Frame_OMC_Pointers |
15.39 ms | 16.22 ms | +5.4% |
Schema_Frame_Many_Resources_References |
117.15 ms | 123.14 ms | +5.1% |
JSON_String_Equal_10 |
5.29 ns | 5.56 ns | +5.1% |
Regex_Period_Md_Dollar |
27.74 ns | 26.13 ns | -5.8% |
JSON_Parse_Decimal |
7.40 us | 6.92 us | -6.5% |
All 103 benchmarks
| Benchmark | main |
This branch | Change |
|---|---|---|---|
Crypto_CRC32_Large_JSONL |
88.65 us | 88.71 us | +0.1% |
JOSE_VerifySignature_RS256 |
19.04 us | 19.03 us | -0.0% |
JOSE_VerifySignature_ES512 |
503.06 us | 502.62 us | -0.1% |
GZIP_Compress_ISO_Language_Set_3_Locations |
24.70 ms | 24.71 ms | +0.1% |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4.30 ms | 4.31 ms | +0.2% |
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations |
5.79 ms | 5.79 ms | +0.0% |
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations |
7.09 ms | 7.01 ms | -1.1% |
GZIP_Compress_ISO_Language_Set_3_Schema |
1.78 ms | 1.79 ms | +0.3% |
GZIP_Decompress_ISO_Language_Set_3_Schema |
266.66 us | 266.64 us | -0.0% |
Markdown_To_HTML_Realistic_Document |
3.98 ms | 4.82 ms | +21.2% |
Markdown_To_HTML_Pathological |
11.08 ms | 11.34 ms | +2.3% |
Markdown_To_HTML_Short_Descriptions |
470.57 ns | 536.33 ns | +14.0% |
HTML_Build_Table_100000 |
29.24 ms | 31.66 ms | +8.3% |
HTML_Render_Table_100000 |
1.88 ms | 1.92 ms | +1.9% |
JSONLD_Catalog_Annotation_List_Populate |
563.62 us | 573.29 us | +1.7% |
JSONLD_Catalog_Materialize |
2.75 ms | 2.89 ms | +5.0% |
JSONL_Parse_Large |
7.49 ms | 9.06 ms | +21.0% |
JSONL_Parse_Large_GZIP |
7.61 ms | 9.25 ms | +21.6% |
URITemplateRouter_Create |
15.76 us | 15.59 us | -1.1% |
URITemplateRouter_Match |
109.20 ns | 110.68 ns | +1.4% |
URITemplateRouterView_Restore |
7.56 us | 7.40 us | -2.0% |
URITemplateRouterView_Match |
93.77 ns | 93.49 ns | -0.3% |
URITemplateRouterView_Arguments |
365.07 ns | 358.18 ns | -1.9% |
URITemplateRouter_Match_BasePath |
125.29 ns | 125.40 ns | +0.1% |
URITemplateRouterView_Match_BasePath |
105.03 ns | 104.99 ns | -0.0% |
JSONPath_Descendant_Filter_Nested |
1.38 us | 1.39 us | +0.7% |
OpenAPI_Format_Synthetic_3_1 |
35.38 ms | 37.44 ms | +5.8% |
Schema_Frame_WoT_References |
1.87 ms | 1.95 ms | +4.6% |
Schema_Frame_OMC_References |
8.20 ms | 8.50 ms | +3.7% |
Schema_Frame_OMC_Pointers |
15.39 ms | 16.22 ms | +5.4% |
Schema_Frame_OMC_Locations |
7.13 ms | 7.33 ms | +2.8% |
Schema_Frame_ISO_Language_Locations |
30.27 ms | 30.17 ms | -0.3% |
Schema_Frame_ISO_Language_Root |
232.70 ns | 234.98 ns | +1.0% |
Schema_Frame_KrakenD_References |
12.73 ms | 14.30 ms | +12.4% |
Schema_Frame_KrakenD_Reachable |
101.56 ms | 109.64 ms | +8.0% |
Schema_Frame_ISO_Language_Locations_To_JSON |
26.64 ms | 30.03 ms | +12.7% |
Schema_Frame_Many_Resources_References |
117.15 ms | 123.14 ms | +5.1% |
Schema_Frame_Deeply_Nested_References |
8.48 ms | 8.71 ms | +2.7% |
Schema_Format_ISO_Language |
35.05 ms | 36.99 ms | +5.5% |
Schema_Bundle_Meta_2020_12 |
468.81 us | 503.76 us | +7.5% |
Schema_Bundle_Many_Remotes_With_Fragments |
5.60 ms | 5.76 ms | +2.9% |
Pointer_Object_Traverse |
18.88 ns | 18.85 ns | -0.1% |
Pointer_Object_Try_Traverse |
20.59 ns | 20.57 ns | -0.1% |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
108.14 ns | 104.91 ns | -3.0% |
Pointer_Walker_Schema_ISO_Language |
1.05 ms | 1.06 ms | +0.8% |
Pointer_Untracked_Deeply_Nested |
982.03 us | 1.13 ms | +15.0% |
Pointer_Tracked_Deeply_Nested |
1.36 ms | 1.54 ms | +12.6% |
Pointer_Position_Tracker_Get_Deeply_Nested |
530.23 ns | 526.95 ns | -0.6% |
Schema_Tracker_ISO_Language |
3.80 ms | 4.29 ms | +12.9% |
Schema_Tracker_ISO_Language_To_JSON |
11.72 ms | 12.69 ms | +8.3% |
JSON_Array_Of_Objects_Unique |
362.63 ns | 363.12 ns | +0.1% |
JSON_Parse_1 |
3.98 us | 4.33 us | +8.8% |
JSON_Parse_Real |
4.19 us | 4.16 us | -0.8% |
JSON_Parse_Decimal |
7.40 us | 6.92 us | -6.5% |
JSON_Parse_Schema_ISO_Language |
2.85 ms | 3.34 ms | +17.4% |
JSON_Parse_Integer |
2.90 us | 2.93 us | +0.9% |
JSON_Parse_String_NonSSO_Plain |
2.99 us | 3.02 us | +0.8% |
JSON_Parse_String_SSO_Plain |
2.32 us | 2.37 us | +2.0% |
JSON_Parse_String_Escape_Heavy |
11.95 us | 12.01 us | +0.5% |
JSON_Parse_Object_Short_Keys |
6.91 us | 8.87 us | +28.4% |
JSON_Parse_Object_Scalar_Properties |
3.48 us | 4.49 us | +29.0% |
JSON_Parse_Object_Array_Properties |
5.37 us | 6.66 us | +24.0% |
JSON_Parse_Object_Object_Properties |
5.36 us | 6.41 us | +19.5% |
JSON_Parse_Nested_Containers |
32.14 us | 32.16 us | +0.0% |
JSON_Fast_Hash_Helm_Chart_Lock |
67.90 ns | 70.59 ns | +4.0% |
JSON_Equality_Helm_Chart_Lock |
141.49 ns | 138.54 ns | -2.1% |
JSON_String_Equal_10 |
5.29 ns | 5.56 ns | +5.1% |
JSON_String_Equal_100 |
6.11 ns | 6.38 ns | +4.4% |
JSON_String_Equal_Small_By_Perfect_Hash_10 |
0.55 ns | 0.55 ns | +0.1% |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 |
10.96 ns | 10.96 ns | +0.0% |
JSON_String_Fast_Hash_10 |
2.43 ns | 2.44 ns | +0.5% |
JSON_String_Fast_Hash_100 |
2.44 ns | 2.45 ns | +0.0% |
JSON_String_Key_Hash_10 |
1.91 ns | 1.91 ns | -0.1% |
JSON_String_Key_Hash_100 |
12.27 ns | 12.27 ns | +0.0% |
JSON_Object_Defines_Miss_Same_Length |
2.73 ns | 2.73 ns | +0.0% |
JSON_Object_Defines_Miss_Too_Small |
2.73 ns | 2.73 ns | -0.1% |
JSON_Object_Defines_Miss_Too_Large |
2.73 ns | 2.73 ns | +0.0% |
JSON_From_String_Copy |
7.17 ns | 7.34 ns | +2.4% |
JSON_From_String_Temporary |
6.75 ns | 6.99 ns | +3.6% |
JSON_Number_To_Double |
15.03 ns | 15.01 ns | -0.1% |
JSON_Object_At_Last_Key_8 |
5.11 ns | 4.91 ns | -3.9% |
JSON_Object_At_Last_Key_32 |
18.27 ns | 18.28 ns | +0.0% |
JSON_Object_At_Last_Key_128 |
70.63 ns | 70.63 ns | +0.0% |
JSON_Object_At_Last_Key_512 |
293.79 ns | 293.66 ns | -0.0% |
JSON_Divisible_By_Decimal |
204.44 ns | 203.01 ns | -0.7% |
JSON_PropertySet_Contains |
38.17 ns | 38.22 ns | +0.1% |
JSON_PropertySet_Filter_Object_Properties |
32.13 ns | 32.11 ns | -0.1% |
JSON_PropertySet_Insert |
338.71 ns | 343.14 ns | +1.3% |
Regex_Lower_S_Or_Upper_S_Asterisk |
1.84 ns | 1.84 ns | -0.0% |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
1.84 ns | 1.84 ns | +0.0% |
Regex_Period_Asterisk |
1.84 ns | 1.84 ns | +0.0% |
Regex_Group_Period_Asterisk_Group |
1.77 ns | 1.77 ns | +0.0% |
Regex_Period_Plus |
1.84 ns | 1.84 ns | -0.0% |
Regex_Period |
1.84 ns | 1.84 ns | +0.0% |
Regex_Caret_Period_Plus_Dollar |
1.84 ns | 1.84 ns | +0.0% |
Regex_Caret_Group_Period_Plus_Group_Dollar |
1.77 ns | 1.77 ns | +0.1% |
Regex_Caret_Period_Asterisk_Dollar |
1.84 ns | 1.84 ns | +0.0% |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
1.84 ns | 1.84 ns | +0.1% |
Regex_Caret_X_Hyphen |
5.11 ns | 5.11 ns | +0.0% |
Regex_Period_Md_Dollar |
27.74 ns | 26.13 ns | -5.8% |
Regex_Caret_Slash_Period_Asterisk |
5.66 ns | 6.20 ns | +9.6% |
Regex_Caret_Period_Range_Dollar |
2.66 ns | 2.66 ns | +0.1% |
Regex_Nested_Backtrack |
33.04 ns | 32.44 ns | -1.8% |
There was a problem hiding this comment.
1 issue found across 3 files (changes from recent commits).
You’re at about 92% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="test/jsonschema/jsonschema_frame_test.cc">
<violation number="1">
P2: This change deletes the two frame tests that this PR added to cover legacy applicators (`draft2_requires_applies_to_the_parent_instance` and `draft3_disallow_holding_a_schema`), and a repo-wide search finds no replacement frame coverage for `requires` (draft-02) or `disallow` (draft-03) — the walker tests in jsonschema_walker_draft2_test.cc / draft3_test.cc cover only the walker's keyword classification, not `SchemaFrame::traverse` into these values. If framing these keyword values as subschemas is still intended (the walker still classifies them as `ApplicatorValueTraverseParent` / `ApplicatorElementsInPlaceSomeNegate`), keep equivalent frame tests; if the frame behavior changed instead, the removed assertions should have been adjusted, not dropped without explanation.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Benchmark
|
| Benchmark | main |
This branch | Change |
|---|---|---|---|
URITemplateRouter_Match |
210.80 ns | 290.51 ns | +37.8% |
JSONLD_Catalog_Materialize |
3.82 ms | 5.24 ms | +36.9% |
Schema_Frame_KrakenD_References |
22.45 ms | 30.71 ms | +36.8% |
Schema_Frame_ISO_Language_Root |
151.71 ns | 197.25 ns | +30.0% |
HTML_Build_Table_100000 |
40.95 ms | 52.78 ms | +28.9% |
Schema_Frame_ISO_Language_Locations_To_JSON |
28.61 ms | 36.71 ms | +28.3% |
JSONLD_Catalog_Annotation_List_Populate |
715.74 us | 915.83 us | +28.0% |
JSONL_Parse_Large_GZIP |
9.29 ms | 11.75 ms | +26.5% |
Schema_Frame_Deeply_Nested_References |
17.19 ms | 21.46 ms | +24.8% |
URITemplateRouter_Create |
26.31 us | 32.83 us | +24.8% |
JSONL_Parse_Large |
8.85 ms | 10.91 ms | +23.3% |
JSON_Equality_Helm_Chart_Lock |
202.44 ns | 248.86 ns | +22.9% |
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations |
7.02 ms | 8.60 ms | +22.6% |
Markdown_To_HTML_Realistic_Document |
4.44 ms | 5.43 ms | +22.2% |
Pointer_Tracked_Deeply_Nested |
1.37 ms | 1.67 ms | +21.7% |
HTML_Render_Table_100000 |
2.49 ms | 3.00 ms | +20.2% |
JSONPath_Descendant_Filter_Nested |
1.68 us | 2.01 us | +19.7% |
JSON_Fast_Hash_Helm_Chart_Lock |
74.69 ns | 88.90 ns | +19.0% |
JSON_String_Equal_Small_By_Perfect_Hash_10 |
0.41 ns | 0.49 ns | +18.5% |
Markdown_To_HTML_Short_Descriptions |
524.17 ns | 620.40 ns | +18.4% |
Schema_Frame_OMC_Locations |
12.24 ms | 14.23 ms | +16.3% |
Schema_Frame_Many_Resources_References |
158.78 ms | 183.84 ms | +15.8% |
Schema_Frame_ISO_Language_Locations |
30.22 ms | 34.98 ms | +15.7% |
JSON_Array_Of_Objects_Unique |
479.04 ns | 549.67 ns | +14.7% |
JOSE_VerifySignature_ES512 |
1.25 ms | 1.44 ms | +14.5% |
Markdown_To_HTML_Pathological |
15.92 ms | 18.16 ms | +14.0% |
Pointer_Untracked_Deeply_Nested |
1.08 ms | 1.23 ms | +13.8% |
JSON_String_Key_Hash_100 |
2.83 ns | 3.21 ns | +13.3% |
Schema_Frame_KrakenD_Reachable |
271.65 ms | 306.08 ms | +12.7% |
Crypto_CRC32_Large_JSONL |
28.05 us | 31.58 us | +12.6% |
URITemplateRouter_Match_BasePath |
261.01 ns | 289.42 ns | +10.9% |
JSON_Parse_1 |
4.32 us | 4.76 us | +10.2% |
GZIP_Decompress_ISO_Language_Set_3_Schema |
379.65 us | 413.53 us | +8.9% |
JSON_Parse_Object_Short_Keys |
7.27 us | 7.84 us | +7.9% |
Regex_Caret_X_Hyphen |
8.36 ns | 9.02 ns | +7.8% |
JOSE_VerifySignature_RS256 |
29.96 us | 32.31 us | +7.8% |
JSON_Parse_Schema_ISO_Language |
3.05 ms | 3.23 ms | +5.8% |
JSON_Parse_String_Escape_Heavy |
21.83 us | 23.06 us | +5.7% |
GZIP_Compress_ISO_Language_Set_3_Schema |
2.36 ms | 2.50 ms | +5.6% |
JSON_String_Equal_10 |
9.23 ns | 9.74 ns | +5.5% |
JSON_Parse_Nested_Containers |
35.39 us | 37.17 us | +5.0% |
Pointer_Object_Traverse |
29.17 ns | 27.47 ns | -5.8% |
JSON_Parse_Real |
7.83 us | 7.37 us | -5.9% |
JSON_PropertySet_Insert |
457.52 ns | 427.41 ns | -6.6% |
Regex_Caret_Period_Asterisk_Dollar |
3.01 ns | 2.79 ns | -7.3% |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.61 ns | 2.41 ns | -7.5% |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
205.55 ns | 187.95 ns | -8.6% |
Schema_Frame_OMC_References |
16.46 ms | 14.78 ms | -10.2% |
Schema_Bundle_Meta_2020_12 |
921.89 us | 827.00 us | -10.3% |
Regex_Period_Plus |
2.71 ns | 2.43 ns | -10.3% |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.47 ns | 2.20 ns | -10.7% |
Schema_Frame_WoT_References |
3.17 ms | 2.82 ms | -11.0% |
JSON_String_Equal_100 |
9.99 ns | 8.89 ns | -11.0% |
Schema_Bundle_Many_Remotes_With_Fragments |
9.20 ms | 8.18 ms | -11.2% |
OpenAPI_Format_Synthetic_3_1 |
69.84 ms | 62.03 ms | -11.2% |
JSON_Object_At_Last_Key_128 |
67.15 ns | 58.63 ns | -12.7% |
Schema_Tracker_ISO_Language |
4.46 ms | 3.89 ms | -12.8% |
JSON_PropertySet_Filter_Object_Properties |
61.76 ns | 53.57 ns | -13.3% |
JSON_Parse_String_NonSSO_Plain |
4.87 us | 4.19 us | -13.9% |
JSON_Parse_String_SSO_Plain |
2.66 us | 2.22 us | -16.6% |
Regex_Period |
2.88 ns | 2.33 ns | -19.1% |
URITemplateRouterView_Restore |
19.97 us | 15.78 us | -21.0% |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.54 ns | 2.79 ns | -21.4% |
JSON_Object_At_Last_Key_512 |
280.95 ns | 213.56 ns | -24.0% |
JSON_Object_At_Last_Key_8 |
5.46 ns | 4.14 ns | -24.0% |
JSON_Number_To_Double |
46.19 ns | 33.68 ns | -27.1% |
Regex_Caret_Period_Plus_Dollar |
3.58 ns | 2.59 ns | -27.5% |
JSON_PropertySet_Contains |
67.97 ns | 47.05 ns | -30.8% |
Pointer_Walker_Schema_ISO_Language |
2.33 ms | 1.55 ms | -33.5% |
JSON_Divisible_By_Decimal |
279.23 ns | 182.97 ns | -34.5% |
JSON_Object_At_Last_Key_32 |
20.21 ns | 13.16 ns | -34.9% |
JSON_From_String_Temporary |
12.58 ns | 6.25 ns | -50.3% |
All 103 benchmarks
| Benchmark | main |
This branch | Change |
|---|---|---|---|
Regex_Lower_S_Or_Upper_S_Asterisk |
1.82 ns | 1.82 ns | +0.4% |
Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar |
2.47 ns | 2.20 ns | -10.7% |
Regex_Period_Asterisk |
2.19 ns | 2.17 ns | -1.3% |
Regex_Group_Period_Asterisk_Group |
2.30 ns | 2.19 ns | -4.7% |
Regex_Period_Plus |
2.71 ns | 2.43 ns | -10.3% |
Regex_Period |
2.88 ns | 2.33 ns | -19.1% |
Regex_Caret_Period_Plus_Dollar |
3.58 ns | 2.59 ns | -27.5% |
Regex_Caret_Group_Period_Plus_Group_Dollar |
3.54 ns | 2.79 ns | -21.4% |
Regex_Caret_Period_Asterisk_Dollar |
3.01 ns | 2.79 ns | -7.3% |
Regex_Caret_Group_Period_Asterisk_Group_Dollar |
2.61 ns | 2.41 ns | -7.5% |
Regex_Caret_X_Hyphen |
8.36 ns | 9.02 ns | +7.8% |
Regex_Period_Md_Dollar |
30.67 ns | 31.44 ns | +2.5% |
Regex_Caret_Slash_Period_Asterisk |
6.21 ns | 6.21 ns | -0.1% |
Regex_Caret_Period_Range_Dollar |
3.10 ns | 3.02 ns | -2.6% |
Regex_Nested_Backtrack |
42.59 ns | 43.11 ns | +1.2% |
JSON_Array_Of_Objects_Unique |
479.04 ns | 549.67 ns | +14.7% |
JSON_Parse_1 |
4.32 us | 4.76 us | +10.2% |
JSON_Parse_Real |
7.83 us | 7.37 us | -5.9% |
JSON_Parse_Decimal |
8.33 us | 7.94 us | -4.6% |
JSON_Parse_Schema_ISO_Language |
3.05 ms | 3.23 ms | +5.8% |
JSON_Parse_Integer |
4.72 us | 4.62 us | -2.1% |
JSON_Parse_String_NonSSO_Plain |
4.87 us | 4.19 us | -13.9% |
JSON_Parse_String_SSO_Plain |
2.66 us | 2.22 us | -16.6% |
JSON_Parse_String_Escape_Heavy |
21.83 us | 23.06 us | +5.7% |
JSON_Parse_Object_Short_Keys |
7.27 us | 7.84 us | +7.9% |
JSON_Parse_Object_Scalar_Properties |
3.50 us | 3.51 us | +0.3% |
JSON_Parse_Object_Array_Properties |
4.76 us | 4.60 us | -3.3% |
JSON_Parse_Object_Object_Properties |
4.56 us | 4.71 us | +3.3% |
JSON_Parse_Nested_Containers |
35.39 us | 37.17 us | +5.0% |
JSON_Fast_Hash_Helm_Chart_Lock |
74.69 ns | 88.90 ns | +19.0% |
JSON_Equality_Helm_Chart_Lock |
202.44 ns | 248.86 ns | +22.9% |
JSON_String_Equal_10 |
9.23 ns | 9.74 ns | +5.5% |
JSON_String_Equal_100 |
9.99 ns | 8.89 ns | -11.0% |
JSON_String_Equal_Small_By_Perfect_Hash_10 |
0.41 ns | 0.49 ns | +18.5% |
JSON_String_Equal_Small_By_Runtime_Perfect_Hash_10 |
5.29 ns | 5.51 ns | +4.1% |
JSON_String_Fast_Hash_10 |
3.36 ns | 3.46 ns | +3.1% |
JSON_String_Fast_Hash_100 |
3.17 ns | 3.11 ns | -1.8% |
JSON_String_Key_Hash_10 |
2.51 ns | 2.54 ns | +1.1% |
JSON_String_Key_Hash_100 |
2.83 ns | 3.21 ns | +13.3% |
JSON_Object_Defines_Miss_Same_Length |
3.57 ns | 3.65 ns | +2.3% |
JSON_Object_Defines_Miss_Too_Small |
3.77 ns | 3.87 ns | +2.7% |
JSON_Object_Defines_Miss_Too_Large |
3.30 ns | 3.37 ns | +2.1% |
JSON_From_String_Copy |
15.00 ns | 15.30 ns | +2.0% |
JSON_From_String_Temporary |
12.58 ns | 6.25 ns | -50.3% |
JSON_Number_To_Double |
46.19 ns | 33.68 ns | -27.1% |
JSON_Object_At_Last_Key_8 |
5.46 ns | 4.14 ns | -24.0% |
JSON_Object_At_Last_Key_32 |
20.21 ns | 13.16 ns | -34.9% |
JSON_Object_At_Last_Key_128 |
67.15 ns | 58.63 ns | -12.7% |
JSON_Object_At_Last_Key_512 |
280.95 ns | 213.56 ns | -24.0% |
JSON_Divisible_By_Decimal |
279.23 ns | 182.97 ns | -34.5% |
JSON_PropertySet_Contains |
67.97 ns | 47.05 ns | -30.8% |
JSON_PropertySet_Filter_Object_Properties |
61.76 ns | 53.57 ns | -13.3% |
JSON_PropertySet_Insert |
457.52 ns | 427.41 ns | -6.6% |
Pointer_Object_Traverse |
29.17 ns | 27.47 ns | -5.8% |
Pointer_Object_Try_Traverse |
49.51 ns | 47.69 ns | -3.7% |
Pointer_Push_Back_Pointer_To_Weak_Pointer |
205.55 ns | 187.95 ns | -8.6% |
Pointer_Walker_Schema_ISO_Language |
2.33 ms | 1.55 ms | -33.5% |
Pointer_Untracked_Deeply_Nested |
1.08 ms | 1.23 ms | +13.8% |
Pointer_Tracked_Deeply_Nested |
1.37 ms | 1.67 ms | +21.7% |
Pointer_Position_Tracker_Get_Deeply_Nested |
456.22 ns | 476.74 ns | +4.5% |
Schema_Tracker_ISO_Language |
4.46 ms | 3.89 ms | -12.8% |
Schema_Tracker_ISO_Language_To_JSON |
15.10 ms | 15.04 ms | -0.4% |
Schema_Frame_WoT_References |
3.17 ms | 2.82 ms | -11.0% |
Schema_Frame_OMC_References |
16.46 ms | 14.78 ms | -10.2% |
Schema_Frame_OMC_Pointers |
29.24 ms | 29.48 ms | +0.8% |
Schema_Frame_OMC_Locations |
12.24 ms | 14.23 ms | +16.3% |
Schema_Frame_ISO_Language_Locations |
30.22 ms | 34.98 ms | +15.7% |
Schema_Frame_ISO_Language_Root |
151.71 ns | 197.25 ns | +30.0% |
Schema_Frame_KrakenD_References |
22.45 ms | 30.71 ms | +36.8% |
Schema_Frame_KrakenD_Reachable |
271.65 ms | 306.08 ms | +12.7% |
Schema_Frame_ISO_Language_Locations_To_JSON |
28.61 ms | 36.71 ms | +28.3% |
Schema_Frame_Many_Resources_References |
158.78 ms | 183.84 ms | +15.8% |
Schema_Frame_Deeply_Nested_References |
17.19 ms | 21.46 ms | +24.8% |
Schema_Format_ISO_Language |
36.39 ms | 37.82 ms | +3.9% |
Schema_Bundle_Meta_2020_12 |
921.89 us | 827.00 us | -10.3% |
Schema_Bundle_Many_Remotes_With_Fragments |
9.20 ms | 8.18 ms | -11.2% |
OpenAPI_Format_Synthetic_3_1 |
69.84 ms | 62.03 ms | -11.2% |
JSONPath_Descendant_Filter_Nested |
1.68 us | 2.01 us | +19.7% |
URITemplateRouter_Create |
26.31 us | 32.83 us | +24.8% |
URITemplateRouter_Match |
210.80 ns | 290.51 ns | +37.8% |
URITemplateRouterView_Restore |
19.97 us | 15.78 us | -21.0% |
URITemplateRouterView_Match |
187.24 ns | 194.10 ns | +3.7% |
URITemplateRouterView_Arguments |
669.35 ns | 698.08 ns | +4.3% |
URITemplateRouter_Match_BasePath |
261.01 ns | 289.42 ns | +10.9% |
URITemplateRouterView_Match_BasePath |
225.50 ns | 215.31 ns | -4.5% |
JSONL_Parse_Large |
8.85 ms | 10.91 ms | +23.3% |
JSONL_Parse_Large_GZIP |
9.29 ms | 11.75 ms | +26.5% |
JSONLD_Catalog_Annotation_List_Populate |
715.74 us | 915.83 us | +28.0% |
JSONLD_Catalog_Materialize |
3.82 ms | 5.24 ms | +36.9% |
HTML_Build_Table_100000 |
40.95 ms | 52.78 ms | +28.9% |
HTML_Render_Table_100000 |
2.49 ms | 3.00 ms | +20.2% |
Markdown_To_HTML_Realistic_Document |
4.44 ms | 5.43 ms | +22.2% |
Markdown_To_HTML_Pathological |
15.92 ms | 18.16 ms | +14.0% |
Markdown_To_HTML_Short_Descriptions |
524.17 ns | 620.40 ns | +18.4% |
GZIP_Compress_ISO_Language_Set_3_Locations |
44.81 ms | 43.28 ms | -3.4% |
GZIP_Decompress_ISO_Language_Set_3_Locations |
4.09 ms | 4.21 ms | +3.1% |
GZIP_Decompress_Default_Level_ISO_Language_Set_3_Locations |
6.11 ms | 5.86 ms | -4.0% |
GZIP_Decompress_Stream_Default_Level_ISO_Language_Set_3_Locations |
7.02 ms | 8.60 ms | +22.6% |
GZIP_Compress_ISO_Language_Set_3_Schema |
2.36 ms | 2.50 ms | +5.6% |
GZIP_Decompress_ISO_Language_Set_3_Schema |
379.65 us | 413.53 us | +8.9% |
JOSE_VerifySignature_RS256 |
29.96 us | 32.31 us | +7.8% |
JOSE_VerifySignature_ES512 |
1.25 ms | 1.44 ms | +14.5% |
Crypto_CRC32_Large_JSONL |
28.05 us | 31.58 us | +12.6% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Juan Cruz Viotti jv@jviotti.com