Repository navigation
Conversation
The Spacefast mark now links to the Website home at the origin root, and the "Docs" label links to the Docs home. A Logo layout override renders the pair; the header CSS that restyled the old single link is removed. verify-routes checks the two links and lets declared Website-owned URLs skip the /docs base check.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No issues found.
All required checks pass on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
|
Warning Review limit reachedYour organization has reached its usage spending cap. Adjust your spending cap in the billing tab. Next included review available in 39 minutes. View limit details
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
# Conflicts: # components.ts
The mark's link leaves the docs' client router, so a router fetch before the full page load was wasted. Fail the build if the configured logo stops resolving to an inline SVG instead of shipping a header without its mark.
The header brand was one link to
/docs/. It is now two links:/(Website home)aria-hidden)/docs/(Docs home)The link rules. Docs only ship inside the Website artifact: the Website build copies
dist/into its own output at/docs. So a root-relative/that skips the deployment base reaches the Website home on whatever origin serves the page: production, the Website's hosted preview, or a local Website build./is already a declared Website-owned URL inscripts/website-dependencies.mjs, so composition checks that the Website serves it. Under standalonebun run devhere,/has no Website behind it, the same as every other Website-owned URL. The label useswithBase("/").The look doesn't change. The mark is 20px tall and the label follows it with an 8px gap and no divider. The label is 600 weight, 16px, foreground color, and truncates on overflow. Each link has its own hover (opacity 0.8). Each keeps the theme's 2px accent
:focus-visibleoutline.Changes
components/Logo.astro: aLogolayout override registered throughdefineComponentsincomponents.ts. It takes Blume'sLogoprops and renders Blume's inlinedcurrentColorwordmark, so the mark follows the theme.blume.config.ts: thelogoconfig already matches (href: "/",text: "Docs"). Added a comment that the component renders two links.theme.css: deleted the[data-blume-header] > a:first-of-typerules. They never matched because the brand link sits inside adiv, not directly under the header. That is why the current header already shows 600 weight with an 8px gap.scripts/verify-routes.mjs:/docs/in the built HTML: the check failed withheader lockup is wrong.No other script asserted on the header logo. The ones I looked at were
docs-experience.test.mjs,verify-built-seo.mjs, andaudit-composed-site.mjs.Verification
Run with
SPACEFAST_PRICING_FIXTURE=test/fixtures/pricing-document.json:Built
dist/quickstart/index.htmlheader, with the SVG elided:Measured in Chromium against the dev server, in both themes: mark height 20px, gap 8px, label 600 weight and 16px, hover opacity 0.8, keyboard focus outline solid 2px.
Summary by CodeRabbit