Skip to content

Show Business limits as Custom, matching Enterprise, instead of TBD - #122

Merged
batuhan merged 4 commits into
mainfrom
business-custom-limits
Nov 9, 2026
Merged

batuhan merged 4 commits into
mainfrom
business-custom-limits

Conversation

@batuhan

@batuhan batuhan commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Business had TBD in every limit row Pro meters. Each of those rows now matches Enterprise, with Enterprise's "Contract" shown as "Custom" for Business. Business keeps its own published prices for compute, MySQL compute, Workers requests and compute, storage, members and included usage.

Concrete cells that now match Enterprise instead of TBD: Disk per Space "Up to 1 TB", memory per request "2 GB", build timeout "2 h", logs "Custom, plus log drains". Everything else is "Custom". Advanced crons and Extra email a day were TBD overrides; they are now Custom like Enterprise.

Deleted: the TBD constant, the TBD badge branch and .sf-tag-tbd style in components/PricingTable.astro, and the TBD row in the fine print.

node --test scripts/pricing.test.mjs passes 3/3, and bun run check passes with no type errors.

Stacked on #121.


Start Proof
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Pricing Updates
    • Business plan pricing now uses “Custom” for unspecified limits and features, replacing “TBD.”
    • The Business at-a-glance table now lists disk storage as “Up to 1 TB” and shows custom pricing for Spaces, custom domains, compute workers, and database backups.
    • Removed the fine-print note that Business limits were undecided and would be set before launch.
    • “TBD” values now appear as ordinary text rather than a badge.

@spacefast
spacefast Bot temporarily deployed to preview/business-custom-limits November 9, 2026 14:01 Inactive
@indent

indent Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Issues

All clear! No issues remaining. 🎉

1 issue already resolved
  • The new Enterprise fallback in withBusiness also converts metered price rows (Dynamic requests, CI compute, Uncached traffic, Bucket storage, Source control storage, Transactional email) to "Custom" for Business. Business is self-serve with list prices, so these rates now look negotiated, and the */† markers have no price to attach to. Add explicit BUSINESS_TEAM overrides with Business's prices, or restrict the fallback to limit rows.
    Found by Indent Review Agent

CI Checks

All required checks passed on c08a741. The non-required Spacefast Builds check fails again with "The runtime API hit a fatal error", the same message as on the previous commit, so it is likely a platform problem. CodeRabbit is still running.

Failing Spacefast Builds
  • The check summary says only "The runtime API hit a fatal error." There are no annotations and no logs. The build page needs a login, so I couldn't read the log. It failed the same way on the previous commit and the PR only changes pricing table code and copy, so the error doesn't look specific to this change. Someone with access should check the build log (https://my.spacefast.com/automattic/sf-docs/builds/bld_1dd4273e9d6a4efc8f9b3499f1311b10).

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · Business metered prices now read as Custom.
Full results

Indent Review Agent

  • Summary: Business metered prices now read as Custom.
  • Last ran on commit: c08a7419
  • Latest result
    {
      "summary": "Business metered prices now read as Custom.",
      "findings": [
        {
          "fix": "Add explicit BUSINESS_TEAM overrides for the metered rows (at least the per-unit price, e.g. \"$0.25 per million\", \"$0.0055 per min\", \"$0.04 per GB\", \"Free now; …, then $0.016 per GB-month*\", \"Free now; …, then $0.07 per GB-month†\", \"…, then $0.50 per 1,000*\"). Or limit the Enterprise fallback to limit rows and fail loudly when a price row has no override.",
          "line": 255,
          "path": "scripts/pricing-next.mjs",
          "issue": "The new fallback copies Enterprise's last value into every row without an override, turning \"Contract\" into \"Custom\". That suits limits, but the Team table also has metered price rows. Dynamic requests, CI compute (builds), Uncached traffic, Bucket storage, Source control storage and Transactional email now read \"Custom\" for Business. Pro shows a real allowance and price for each (e.g. \"10 million, then $0.25 per million\"). Business is a self-serve $500 plan: the Included usage row says it \"pays for every metered resource on this page, at the listed prices\", and the pricing FAQ says usage past $500 is \"added on top\". Readers now see those Business rates as negotiated or unknown, unlike Compute/Storage/Workers rows, which show list prices. The Bucket storage (Beta *) and Source control storage (Complimentary †) rows keep their badges, but the Business cell has no price for the */† to apply to.",
          "title": "Business metered prices fall back to \"Custom\" (from Enterprise's \"Contract\")",
          "severity": "bug"
        }
      ]
    }

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

Business pricing now uses updated fallback rules and specified values instead of TBD entries. Pricing cells render TBD values as ordinary text, and the pricing page no longer includes the note that Business limits were undecided.

Changes: Business pricing

Layer / File(s) Summary
Business pricing values and fallback
scripts/pricing-next.mjs
withBusiness uses Pro values for specified non-limit values and otherwise uses Enterprise values, converting Contract to Custom. Business overrides and at-a-glance values are updated.
Pricing display and terms
components/PricingTable.astro, content/(account)/pricing.mdx
TBD values render as ordinary text, the TBD styling is removed, and the Fine print table no longer says Business limits were undecided.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

  • spacefast/docs#115: Adds the draft pricing data and withBusiness fallback that this PR updates.

Suggested reviewers: alexanderaidun-a8c

Merge Risk: Minimal · up to c08a7

Business pricing now shows the intended limits, with no identified merge-blocking issue.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T14:01:55.453520Z
We couldn’t complete this review. Comment @codex review to try again.
d6beb0f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

Comment thread scripts/pricing-next.mjs Resolved
@batuhan
batuhan changed the base branch from business-included-usage to main November 9, 2026 14:32
@spacefast
spacefast Bot temporarily deployed to preview/business-custom-limits November 9, 2026 14:33 Inactive
@batuhan
batuhan merged commit bd61ed5 into main Nov 9, 2026
5 of 7 checks passed
@batuhan
batuhan deleted the business-custom-limits branch November 9, 2026 14:39

This branch was previously deployed

1 inactive deployment
preview/business-custom-limits — c08a7419 Deployed Nov 9, 2026 by spacefast[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant