Skip to content

Remove the recipe gallery and its publishing - #13

Open
batuhan wants to merge 1 commit into
move-code-recipesfrom
remove-recipes
Open

batuhan wants to merge 1 commit into
move-code-recipesfrom
remove-recipes

Conversation

@batuhan

@batuhan batuhan commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Recipes now live and publish from their own repository. spacefast/examples keeps only framework and migration examples, so this removes what was left of the recipe machinery after #12.

Deleted:

  • recipes/ (every remaining recipe folder, plus README.md, TEMPLATE.md, meta.example.json)
  • scripts/build-manifest.mjs, scripts/catalog.test.mjs, scripts/validate-publish-dir.mjs (and the now-empty scripts/)
  • The manifest, deploy-manifest, discover-recipes, and publish-recipes jobs in .github/workflows/publish.yml, the pages: write / id-token: write permissions, and the only dispatch input; the workflow is now "Validate examples" and keeps the examples build matrix unchanged
  • The recipes/ row, the "Recipes integration" section, and the recipe/manifest sentences in README.md

The .gitignore is unchanged: dist/ is still used by the Astro and migration examples. The badge.js / data-example tags in the moved examples are the shared example badge and stay.

Stacked on #12.

🤖 Generated with Claude Code


Show it working
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

Recipes now live and publish from their own repository. This repository keeps
only framework and migration examples.

Deleted the remaining recipes/ folders, the manifest builder, the catalog test,
the publish-directory validator, and the manifest, deploy-manifest,
discover-recipes, and publish-recipes workflow jobs together with the Pages
and id-token permissions they needed. The workflow is now "Validate examples"
and only runs the examples build matrix.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-08T23:28:45.661974Z
We couldn’t complete this review. Comment @codex review to try again.
f298c34 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1edf1566-a4f1-4e26-a070-d9942631ffc8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@indent

indent Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Issues

1 potential issue found:

  • spacefast/www src/loaders/recipes.ts still defaults to https://spacefast.github.io/examples/manifest.json, and its sf.jsonc redirects /examples/manifest.json there. With the manifest jobs and pages: write removed, that Pages site stays frozen, so recipe changes from the new recipes repo won't reach spacefast.com/recipes until www points at the new feed.
    Found by Indent Review Agent

↑ Select any checkbox above to have Indent auto-fix the issue

CI Checks

All CI checks passed on f298c34.

Review agents

Select any unchecked box below to run or rerun that agent.

Found issues (1)
  • Indent Review Agent · No bugs; www still reads the old recipe feed
Full results

Indent Review Agent

  • Summary: No bugs; www still reads the old recipe feed
  • Last ran on commit: f298c343
  • Latest result
    {
      "summary": "No bugs; www still reads the old recipe feed",
      "findings": [
        {
          "fix": "Before or alongside merging, move www's default manifest URL and the `sf.jsonc` redirect to wherever the new recipes repo publishes its feed. Until then, leave this repo's GitHub Pages deployment published.",
          "path": ".github/workflows/publish.yml",
          "issue": "spacefast/www's `src/loaders/recipes.ts` still defaults to `https://spacefast.github.io/examples/manifest.json`, and its `sf.jsonc` redirects `/examples/manifest.json` there. With the `manifest`/`deploy-manifest` jobs and `pages: write` removed, that Pages site stays frozen at its last deployment. Recipe changes published from the new recipes repo won't show up on spacefast.com/recipes until www points somewhere else. If someone later unpublishes this repo's Pages site, the www recipe loader fails. This isn't a regression in this PR, since the base branch had already deleted `scripts/catalog.test.mjs`, which the manifest job needed.",
          "title": "spacefast.com/recipes still reads this repo's Pages feed, which will no longer update",
          "severity": "nit"
        }
      ]
    }

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant