Skip to content

Fix "Log4j API could not find a logging provider" - #312

Merged
goneall merged 2 commits into
spdx:masterfrom
bact:dep-log4j-to-slf4j
Sep 18, 2026
Merged

goneall merged 2 commits into
spdx:masterfrom
bact:dep-log4j-to-slf4j

Conversation

@bact

@bact bact commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

When running mvn verify, got this error message:

main ERROR Log4j API could not find a logging provider.

Apache POI (used by the spreadsheet store) uses log4j-api.
Our project uses slf4j-simple provider, so add log4j-to-slf4j as adapter, to fix the error.

Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
@bact bact added the dependencies Pull requests that update a dependency file label Jul 31, 2026
@bact
bact requested a review from goneall July 31, 2026 09:47
@bact bact mentioned this pull request Jul 31, 2026
25 tasks
@goneall

goneall commented Jul 31, 2026

Copy link
Copy Markdown
Member

I recall a past issue where it was requested that we not specify a specific logging provider. That may have been an issue with a library, however (it was some time ago).

Before merging this in, we should find the previous issue and make sure this change doesn't re-introduce it.

@bact
bact marked this pull request as draft July 31, 2026 18:18
@goneall

goneall commented Sep 18, 2026

Copy link
Copy Markdown
Member

@bact - this is marked as draft, but it looks ready to go - let me know if it's OK to merge

@bact
bact marked this pull request as ready for review September 18, 2026 09:26
@bact

bact commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@goneall I have mark this are ready again so you can merge it.
Was marked it as draft because of the earlier comment:

I recall a past issue where it was requested that we not specify a specific logging provider. That may have been an issue with a library, however (it was some time ago).

Before merging this in, we should find the previous issue and make sure this change doesn't re-introduce it.

Relevant logging comment may be this one from @pmonks ?

#153 (comment)

@goneall

goneall commented Sep 18, 2026

Copy link
Copy Markdown
Member

@bact - In reviewing the related issues / PR's, I'm reasonably confident this won't re-introduce the errors - so I'll go ahead and merge.

@vargenau @pmonks - Just a heads up that there is a small possibility this may re-introduce a previous issue #153

@goneall
goneall merged commit b0894e2 into spdx:master Sep 18, 2026
1 check passed
@pmonks

pmonks commented Sep 18, 2026

Copy link
Copy Markdown

My understanding is that tools-java is an application, rather than a library, in which case it should include a logging implementation in the classpath.

The general rule about not providing logging implementations (so as to allow downstream consumers to use whichever implementation they wish) only applies to libraries.

@bact
bact deleted the dep-log4j-to-slf4j branch September 18, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants