Fix "Log4j API could not find a logging provider" - #312
Conversation
Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
|
I recall a past issue where it was requested that we not specify a specific logging provider. That may have been an issue with a library, however (it was some time ago). Before merging this in, we should find the previous issue and make sure this change doesn't re-introduce it. |
|
@bact - this is marked as draft, but it looks ready to go - let me know if it's OK to merge |
|
@goneall I have mark this are ready again so you can merge it.
Relevant logging comment may be this one from @pmonks ? |
|
My understanding is that tools-java is an application, rather than a library, in which case it should include a logging implementation in the classpath. The general rule about not providing logging implementations (so as to allow downstream consumers to use whichever implementation they wish) only applies to libraries. |
When running
mvn verify, got this error message:Apache POI (used by the spreadsheet store) uses
log4j-api.Our project uses
slf4j-simpleprovider, so addlog4j-to-slf4jas adapter, to fix the error.