Skip to content

Dependencies Upgrade: Bump react router from 6.30.3 to 6.30.5 - #8461

Open
CarolineDenis wants to merge 1 commit into
mainfrom
issue-8460
Open

Dependencies Upgrade: Bump react router from 6.30.3 to 6.30.5#8461
CarolineDenis wants to merge 1 commit into
mainfrom
issue-8460

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Fixes #8460

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

  • general testing

Summary by CodeRabbit

  • Chores
    • Updated the application’s routing library to a newer maintenance release.

@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e97077bd-2636-4b46-be46-97c84e2bf183

📥 Commits

Reviewing files that changed from the base of the PR and between 15a06a6 and 0472152.

⛔ Files ignored due to path filters (1)
  • specifyweb/frontend/js_src/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • specifyweb/frontend/js_src/package.json

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The frontend package manifest updates react-router-dom from ^6.30.3 to ^6.30.5.

Changes

React Router Update

Layer / File(s) Summary
Update React Router DOM version
specifyweb/frontend/js_src/package.json
The declared react-router-dom version changes from ^6.30.3 to ^6.30.5.

Suggested reviewers: g1rly-c0d3r

Merge Risk: ⚪ Minimal · up to 04721

This is a localized dependency patch update with no actionable merge-blocking risk remaining; it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Testing Instructions ⚠️ Warning The testing instructions are not clear or component-specific. The pull request changes react-router-dom, which is used by the central EntrypointRouter, application Router, route conversion, navi… Replace general testing with actionable instructions. From specifyweb/frontend/js_src, run npm test (or list the exact required checks). Also verify the central entry points, authenticated route navigation, redirects, overlays, back/f…
Linked Issues check ❓ Inconclusive The reviewed change updates react-router-dom from ^6.30.3 to ^6.30.5, which matches issue #8460. Verification is incomplete because package-lock.json was excluded by the !**/package-lock.json path fil… Include package-lock.json in the review or confirm that its dependency entries are consistent with the requested React Router upgrade.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the React Router dependency upgrade from version 6.30.3 to 6.30.5.
Out of Scope Changes check ✅ Passed The only reviewed change is the react-router-dom version update in package.json. This change is directly related to issue #8460, and no unrelated code changes are present.
Automatic Tests ✅ Passed PASS — the PR is a dependency-only update. The diff changes only package.json and package-lock.json; it adds no application behavior or testable feature. New automatic tests are not necessary. The…
Full details: Linked Issues check

Explanation

The reviewed change updates react-router-dom from ^6.30.3 to ^6.30.5, which matches issue #8460. Verification is incomplete because package-lock.json was excluded by the !**/package-lock.json path filter.

Full details: Automatic Tests

Explanation

PASS — the PR is a dependency-only update. The diff changes only package.json and package-lock.json; it adds no application behavior or testable feature. New automatic tests are not necessary. The repository already has router-focused tests, and CI runs the frontend typecheck and Jest suite.

Full details: Testing Instructions

Explanation

The testing instructions are not clear or component-specific. The pull request changes react-router-dom, which is used by the central EntrypointRouter, application Router, route conversion, navigation, overlays, redirects, and many frontend components. The only instruction is general testing; it gives no test command and no route, navigation, redirect, overlay, or unload-protection scenarios to verify.

Resolution

Replace general testing with actionable instructions. From specifyweb/frontend/js_src, run npm test (or list the exact required checks). Also verify the central entry points, authenticated route navigation, redirects, overlays, back/forward navigation, and unload protection. Include representative affected components such as Header, SchemaConfig, FormEditor, Formatters, and WorkBench.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch issue-8460

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CarolineDenis
CarolineDenis requested a review from a team August 27, 2026 10:40

@g1rly-c0d3r g1rly-c0d3r left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • general testing

Looks good! I didn't find any issues, I did my best to look through everything.

@CarolineDenis
CarolineDenis requested a review from a team August 28, 2026 10:27
@CarolineDenis

Copy link
Copy Markdown
Contributor Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@JDAM2k4 JDAM2k4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seemed to run smoothly, but in using the saved Tissue Report, the countries are unable to be found by the query.

Image This doesn't seem to break the ability to use the Report Builder itself, but it does render that saved template unusable. Image

@kwhuber kwhuber left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • general testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Bump React Router

4 participants