Skip to content

feat(css-map): add some canvas classes for 1.2.86#3867

Open
Mythicsoul wants to merge 2 commits into
spicetify:mainfrom
Mythicsoul:feature/map-css-classes
Open

feat(css-map): add some canvas classes for 1.2.86#3867
Mythicsoul wants to merge 2 commits into
spicetify:mainfrom
Mythicsoul:feature/map-css-classes

Conversation

@Mythicsoul

@Mythicsoul Mythicsoul commented Jun 20, 2026

Copy link
Copy Markdown

Added canvas related classes, one that controls the canvas width and another responsible for the dimming effect.
I am not entirely sure whether I chose the correct names to map to, hopefully this is done correctly.

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated the Now Playing view styling configuration by adding new CSS-module class mappings to improve interface presentation.
  • Bug Fixes

    • Resolved missing/incorrect style references in the Now Playing view by introducing the required class mappings.

@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2e9a0c1c-ab32-48e0-b498-42246ae3c655

📥 Commits

Reviewing files that changed from the base of the PR and between a96f877 and e051c45.

📒 Files selected for processing (1)
  • css-map.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • css-map.json

📝 Walkthrough

Walkthrough

Two new entries are added to css-map.json under the main-nowPlayingView namespace: main-nowPlayingView-canvasVisualEnhancement and main-nowPlayingView-container, each mapping a hashed CSS module ID to its corresponding class name.

Changes

CSS Map Update

Layer / File(s) Summary
Add nowPlayingView CSS mappings
css-map.json
Inserts two new hashed-ID-to-class-name mappings for main-nowPlayingView-canvasVisualEnhancement and main-nowPlayingView-container.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • spicetify/cli#3782: Adds additional main-nowPlayingView-* CSS-module mappings to the same file and namespace.

Suggested reviewers

  • rxri

🐇 A hop, a skip, two classes appear,
canvasVisualEnhancement brings canvas near,
container joins the map with glee,
Now playing views as bright as can be!
The CSS map grows, one hash at a time~ 🎵

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'feat(css-map): add some canvas classes for 1.2.86' accurately describes the main change in the pull request, which adds canvas-related CSS classes to the CSS map.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@css-map.json`:
- Around line 1058-1059: Remove the trailing tab character at the end of line
1059 after the comma in the JSON entry for the key "zjCIcN96KsMfWwRo" with value
"main-nowPlayingView-container". Ensure the line ends cleanly with just the
comma and no trailing whitespace.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8b25dc30-fc03-4806-98e9-c3ec56570edf

📥 Commits

Reviewing files that changed from the base of the PR and between 4240b1c and a96f877.

📒 Files selected for processing (1)
  • css-map.json

Comment thread css-map.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant