Repository navigation
Conversation
A wait on the clock passes on a quiet machine and fails on a loaded one, which is what a flake is: of 45 failed fleet gates in two days of spin, the real flakes were each a bound the machine's load outran. A time.Sleep of a constant second or more in a test's body - a subtest's or a goroutine's included - is reported with its length; under a second paces a loop, a computed duration is not a number to judge, and a helper's sleep is the helper's. The allowlist carries the ones whose only signal is the clock, each with its why. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…the clock Nine of spin's 43 were a loop's pacing: for deadline...; time.Sleep(2s). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
aledbf
force-pushed
the
testquality/waits
branch
from
October 25, 2026 18:18
76a45c6 to
4740256
Compare
Contributor
Author
|
Replaced by the same commits at main's head (#68). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second half of the flake work after spin's tally (go-tools#65 is the first): a
time.Sleepof a constant second or more in a test's body, closures included, is reported asTestX sleeps 5s for nothing it can see. Under a second paces a loop and is not flagged; a computed duration is not a number to judge; a helper's sleep is the helper's, one line to fix however many tests call it. The allowlist ratchet is the existing one (-allow, keyedpackage:Test), so the sleeps whose only signal is the clock are carried with their why.On spin it finds 42 tests today (12 in internal/runner/vmm's integration lane, 5 in volumes', 17 in internal/e2e); spin's PR adds them to its allowlist with each sleep's own reason, and the list only shrinks from there.
Fixture
waits: a second, a subtest's and a goroutine's sleep,time.Minute + 500ms, and what is not flagged (under a second, a variable, a helper, another type'sSleep,time.After). Docs and README updated. Lint, test, mutate 0 survivors, site.🤖 Generated with Claude Code