Use regexp on K3sRestarter.Restart()#705
Open
Shunpoco wants to merge 1 commit into
Open
Conversation
Use regexp to treat a custom systemd service name. Signed-off-by: Shunpoco <tkngsnsk313320@gmail.com>
vdice
reviewed
Jun 8, 2026
vdice
left a comment
vdice
left a comment
Collaborator
There was a problem hiding this comment.
I like how the regex simplifies the code! My only reservation is around the case when no k3s service is found; then the error may not be obvious (the code will run systemctl restart with an empty string). However, perhaps that is only a theoretical scenario.
What do you think? Should we check for an empty string? Or perhaps go with this for now and revisit if/when it becomes an issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Use regexp on K8sRestarter.Restart() so that it treats a custom systemd service name like k3s-xxx.service.
Issue ticket number and link
close #630
Checklist before requesting a review