Skip to content

Polish note about @ConfigurationProperties can't be refreshed#1466

Open
quaff wants to merge 1 commit into
spring-cloud:mainfrom
quaff:patch-19
Open

Polish note about @ConfigurationProperties can't be refreshed#1466
quaff wants to merge 1 commit into
spring-cloud:mainfrom
quaff:patch-19

Conversation

@quaff

@quaff quaff commented Feb 7, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@spencergibb

Copy link
Copy Markdown
Member

Your change implies other types can't be refreshed. Can you describe why you want this change?

@quaff

quaff commented Feb 7, 2025

Copy link
Copy Markdown
Contributor Author

Your change implies other types can't be refreshed. Can you describe why you want this change?

My point is not only Java Records but any type using constructor binding.

See https://github.com/spring-projects/spring-boot/blob/1e73a7cf8b376ea4b5ead9e56df093e5354c4de7/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/context/properties/bind/BindMethod.java#L33C18-L33C43

@spencergibb

Copy link
Copy Markdown
Member

Then say that rather than value object.

@spencergibb spencergibb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change value object to something about constructor binding.

Signed-off-by: Yanming Zhou <zhouyanming@gmail.com>
@quaff

quaff commented Feb 8, 2025

Copy link
Copy Markdown
Contributor Author

I copied terms from Javadoc of Spring Boot, WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants