Repository navigation
Fixes potential NPE in getServices and getAllInstances - #1041
Conversation
spencergibb
left a comment
There was a problem hiding this comment.
Assuming PR builds cleanly, LGTM
|
Thanks, @ryanjbaxter! I tested this PR (adf81bb, installed locally as 5.0.5-SNAPSHOT) against 5.0.4 with a reactive Spring Cloud Gateway that uses discovery routes (Spring Boot 4.1.1, Spring Cloud 2025.1.4) and Consul 2.1.0: three servers with persistent data, plus a client agent the gateway talks to. To reproduce the issue, I stopped two of the three servers (no quorum, so the agent answers 500 "No cluster leader"), triggered a route refresh with
Two notes:
LGTM! |
Fixes #1040