Add sheet name selection to Excel readers - #218
Open
Adrastopoulos wants to merge 1 commit into
Open
Conversation
Signed-off-by: Gabriel Hall <gabriel.hall@cox.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add
setSheetNames(String...)toAbstractExcelItemReader.Default behavior remains the same...
When names are configured, it skips non-matching sheets before creating a
RowSet, so skipped-row callbacks and row mapping run only for selected sheets. Multiple configured names still follow workbook order. This works for bothPoiItemReaderand the streaming readers because selection happens in the abstract reader lifecycle.Tests
SheetSelectionTestscovers the default, multiple selected names in workbook order, and no match.Closes #95