Fix UnifiedJedis watch transaction state#3398
Open
hutiefang76 wants to merge 1 commit into
Open
Conversation
Closes spring-projects#3392 Signed-off-by: hutiefang76 <137664623+hutiefang76@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3392
UnifiedJedis.watch()pins a connection by creating a transaction object beforeMULTI. The connection therefore reported queueing too early, so reads betweenWATCHandMULTIpolluted the expectedEXECresult count.This change distinguishes WATCH-only state from an active MULTI transaction. Commands before MULTI run immediately on the pinned connection, while incompatible pipeline, subscription, and cursor operations are rejected.
Tests cover typed and raw reads, EXEC result alignment, pipeline/subscription guards, and SCAN variants. The focused Jedis suite passes 813 tests with 0 failures or errors (64 skipped).
I used AI-assisted review for edge-case analysis and verified the root cause, implementation, and tests locally.