Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve nullability for nullable Kotlin properties represented by a
oneOfschema.The
Any?handling introduced in #3339 identifies schemas without adirect
$ref,type, ortypesconstraint as unconstrained schemas.However, composed
oneOfschemas also lack those fields. They aretherefore mistaken for
Anyschemas and returned without applyingKotlin nullability.
This causes nullable composed properties to be generated incorrectly:
nullable: true.{ "type": "null" }alternative.Treat
oneOfas a schema constraint so these properties are no longerclassified as unconstrained schemas. For OpenAPI 3.1, add a
nullalternative to the existing
oneOf. For OpenAPI 3.0, allow the existingnullable: truehandling to apply.Tests
Extend the Kotlin WebMVC snapshot tests with a nullable sealed-class
property for both OpenAPI 3.0 and OpenAPI 3.1.
The commits are separated so the first records the existing incorrect
output and the second applies the fix and updates the expected output.
mvn \ -pl springdoc-openapi-tests/springdoc-openapi-kotlin-webmvc-tests \ -am \ -Dtest=SpringDocApp18Test,SpringDocApp23Test \ -Dsurefire.failIfNoSpecifiedTests=false \ test