Conversation
- Add the version 5 removals to the removed-options list, so they no longer pass silently - Name the replacement option in the error message - Reword "no more supported" as "no longer supported" Assisted-by: Claude Code Opus 5 <noreply@anthropic.com>
mosabua
force-pushed
the
reject-removed-v5-options
branch
from
September 28, 2026 05:58
3ac7808 to
d02932e
Compare
Author
|
One more instance of the same phrasing that I deliberately left out of this PR, since it is documentation rather than the error message this change touches: https://github.com/sql-formatter-org/sql-formatter/blob/master/docs/paramTypes.md#L87 That is the only remaining occurrence in the repository outside |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #981.
validateConfigalready rejects options removed in version 10, but the version 5removals were never added to that list, so
indentanduppercasewere acceptedand ignored. A config carried across the version 5 upgrade kept formatting
successfully while quietly falling back to the defaults.
This adds them to the same list, and turns it into a map so the error can name
the replacement:
It also rewords the shared message from "is no more supported" to "is no longer
supported", which reads better in English. That touches the six existing entries
and their assertions too, so say the word if you would rather keep the current
wording and I will drop that part.
I considered rejecting every unrecognized key instead, but that is a larger
behavior change and could break callers that pass extra properties. Extending
the existing list covers the upgrade path that actually breaks.
Tests added alongside the existing removed-option tests in
test/sqlFormatter.test.ts. Full suite passes locally: 27 suites, 5887 tests.