[PiyushSatyarthi]

On Python 3.13+, sqlite3 warns when a connection is garbage collected without being closed. Running the unit tests on Linux with CPython 3.14 prints more than 20 ResourceWarning: unclosed database lines. CI only runs 3.14 on Windows, so they don't show up there.

Most of the warnings come from the tests, but one is a real leak in sqlmap itself:

• lib/utils/sqlalchemy.py: SQLAlchemy.close() (inherited from the generic connector) only returns the connection to the engine's pool. The underlying DBAPI connection stays open, for example the sqlite3 connection with -d sqlite://.... close() now also disposes the engine.
• lib/core/testing.py: vulnTest() used with sqlite3.connect(...). sqlite3's context manager commits but does not close, so it now uses contextlib.closing() with an explicit commit.
• tests/test_multibit.py, tests/test_sqlalchemy.py: close the connections the tests open.

Proof

Linux, CPython 3.14.7, python3 -B -W always::ResourceWarning -m unittest discover -s tests -p "test_*.py":

• before: Ran 2751 tests ... OK (skipped=10), with 20+ unclosed database warnings
• after: Ran 2751 tests ... OK (skipped=10), with no unclosed database warnings

The sqlalchemy.py change is what fixes the connector leak, not just the test cleanup. With only that file reverted, tests.test_sqlalchemy still warns even though the test calls sa.close():

$ python3 -B -W always::ResourceWarning -m unittest tests.test_sqlalchemy   # without the sqlalchemy.py change
OK
<sys>:0: ResourceWarning: unclosed database in <sqlite3.Connection object at 0x7fe2e5977d30>

$ python3 -B -W always::ResourceWarning -m unittest tests.test_sqlalchemy   # with it
OK

python3 -W always::ResourceWarning sqlmap.py --vuln-test (which runs the changed vulnTest() code) ends with vuln test final result: PASSED and no unclosed database warnings.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.