Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ npm test # the check CI runs: biome, typecheck, and the frontend unit tests
```

`npm test` checks the entire frontend codebase (html, css, js, ts).
Biome also rejects promise-valued conditions and synchronous callbacks that discard
promises (`noMisusedPromises`), awaiting synchronous values (`useAwaitThenable`),
and runtime import cycles (`noImportCycles`). Type-only imports may form cycles.
Keep async Playwright assertions and actions awaited or returned;
`noPlaywrightMissingAwait` checks these even when TypeScript inference cannot
follow the shared fixture's types. The promise and Playwright rules are in
Biome's nursery group, so review their diagnostics when upgrading Biome.

## Testing

Expand Down
8 changes: 7 additions & 1 deletion biome.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,13 @@
"linter": {
"rules": {
"nursery": {
"noFloatingPromises": "error"
"noFloatingPromises": "error",
"noMisusedPromises": "error",
"useAwaitThenable": "error",
"noPlaywrightMissingAwait": "error"
},
"suspicious": {
"noImportCycles": "error"
}
}
}
Expand Down
Loading