[joachimmetz]

No description provided.

[joachimmetz]

@sshock PTAL, note that I'm not too familiar with the code base

[sshock]

Thanks @joachimmetz. This is much appreciated. I'll take a look when I can 😉.

[sshock]

workflows use --enable-s3 which builds s3_glue.cpp, which is failing with this:

s3_glue.cpp: In function 'int s3::object_put(std::string, std::string, const char*, size_t, const s3headers*)':
s3_glue.cpp:644:5: error: 'af_MD5' was not declared in this scope

please add #include "afflib.h" to s3_glue.cpp, and then we'll run the workflows again...

[joachimmetz]

Done, also note that Distributed under the Berkeley 4-part license in afflib.h might not be sufficient and a still requires a Copyright statement. Suggested

// SPDX-License-Identifier: BSD-4-Clause
// Copyright (c) [Year], [Your Name/Organization]. All rights reserved.

But it might be better that you as the maintainer make copyright related changes (given optics). Can create an issue as reminder if you want.

[sshock]

Thanks. Hoping I can take a closer look at this PR soon.

Let's discuss copyright statements separately. I was not aware that anything needed to be clarified. Can you create a discussion?

[joachimmetz]

Let's discuss copyright statements separately. I was not aware that anything needed to be clarified. Can you create a discussion?

sure, done #68