[siegfriedweber]

Description

Follow-ups to #888, which collected the containerdebug logs.

Create the containerdebug log directory before containerdebug starts. Setting FILE_LOG_MAX_FILES enables the pruning of old log files in the telemetry library, and that pruning runs before the first file is created. On a fresh Pod it therefore reads a directory which does not exist yet, and every container start printed

Error reading the log directory/files: No such file or directory (os error 2)

The message is harmless, because the appender creates the directory together with the file right afterwards, but it reads like a failure. The mkdir reads $FILE_LOG_DIRECTORY rather than the path, so an envOverrides entry for that variable creates the directory which containerdebug actually writes to. It is added in container_debug_command(), whose lines the callers join with "\n", so all roles are covered at once.

Two smaller things in the same area: the value of FILE_LOG_DIRECTORY is now derived from STACKABLE_LOG_DIR with concatcp! instead of being formatted at run time, and the comment on the log volume size limit is shortened to the two facts that matter.

Part of stackabletech/issues#909

Definition of Done Checklist

• Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
• Please make sure all these things are done and tick the boxes

Author

• Changes are OpenShift compatible
• Helm chart can be installed and deployed operator works
• Integration tests passed locally:

  PASS: kuttl/harness/smoke_airflow-3.3.2_openshift-false_executor-celery (375.83s)
  PASS: kuttl/harness/smoke_airflow-3.3.2_openshift-false_executor-kubernetes (316.68s)
  

• Changes need to be "offline" compatible

Reviewer

• Code contains useful comments
• Code contains useful logging statements
• (Integration-)Test cases added
• Documentation added or updated. Follows the style guide.
• Changelog updated
• Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

• Feature Tracker has been updated
• Proper release label has been added
• Links to generated (nightly) docs added
• Release note snippet added
• Add type/deprecation label & add to the deprecation schedule
• Add type/experimental label & add to the experimental features tracker