fix(docker): Keep npm and its bundled dependencies out of the runtime image - #324
Merged
Merged
Conversation
dervoeti
moved this from Development: Waiting for Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Image scans report CVEs for packages that are not part of the application and not in the SBOM. These come from npm itself, the base stage unpacks the full Node.js tarball into
/usr/localand the final stage inherited from it.I split the raw UBI image into its own
basestage. The full Node.js distribution now lives in anodestage used only bybuilder,prod-depsandsbom.finalbuilds onbaseand copies just thenodebinary.microdnf update -ywas moved intofinal, since it no longer inherits it.