Repository navigation
Add TLS verification toggle to trino - #458
Open
Bohreromir wants to merge 5 commits into
Open
Bohreromir wants to merge 5 commits into
Bohreromir wants to merge 5 commits into
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Bohreromir
marked this pull request as ready for review
November 10, 2026 20:33
Bohreromir
force-pushed
the
feat/trino-connection-tls-impersonation
branch
from
November 10, 2026 20:50
5fff85b to
8596c50
Compare
labrenbe
self-requested a review
November 11, 2026 10:45
labrenbe
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Bohreromir
force-pushed
the
feat/trino-connection-tls-impersonation
branch
from
November 12, 2026 11:08
18eea7c to
41d33b1
Compare
Bohreromir
changed the title
Bohreromir
force-pushed
the
feat/trino-connection-tls-impersonation
branch
from
November 12, 2026 11:55
41d33b1 to
811b728
Compare
…nnection form Connections entered on /trino could neither skip TLS certificate verification nor turn off user impersonation. - "Skip TLS certificate verification" toggle, only shown and accepted when STACKABLE_COCKPIT_TRINO_ALLOW_INSECURE_TLS=true (Helm: trino.tls.allowInsecureUserConnections) - "Impersonate the logged-in user" toggle for basic auth, defaulting to STACKABLE_COCKPIT_TRINO_USER_IMPERSONATION - Both settings are persisted in local storage; the connection summary shows "TLS unverified" when verification is skipped
Per-user connections use the deployment's impersonation setting (STACKABLE_COCKPIT_TRINO_USER_IMPERSONATION) again, as before. The TLS verification option stays.
…ABLE_COCKPIT_TRINO_ALLOW_INSECURE_TLS The variable skips TLS certificate verification for the pre-configured connection and, without STACKABLE_COCKPIT_TRINO_URL, lets users skip it for their own. The Helm value trino.tls.insecure becomes trino.tls.allowInsecure.
Bohreromir
force-pushed
the
feat/trino-connection-tls-impersonation
branch
from
November 12, 2026 13:39
b0e7b86 to
cbf7e08
Compare
STACKABLE_COCKPIT_TRINO_ALLOW_INSECURE_TLS both skipped verification for the pre-configured connection and let users skip it for their own, depending on whether STACKABLE_COCKPIT_TRINO_URL was set. - STACKABLE_COCKPIT_TRINO_TLS_INSECURE (trino.tls.insecure) skips verification for the pre-configured connection, as on main. - STACKABLE_COCKPIT_TRINO_USER_CONNECTION_TLS_ALLOW_INSECURE (trino.userConnection.tls.allowInsecure) lets users skip it for the connection they enter in the UI. Cockpit and the Helm chart reject either setting where it has no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add TLS verification and impersonation options to user created trino connections
Docs
Release note
Checklist
Author
Reviewer
Acceptance