Repository navigation
fix(server): Close the database pool on shutdown - #466
Open
Bohreromir wants to merge 2 commits into
Open
Bohreromir wants to merge 2 commits into
Bohreromir wants to merge 2 commits into
Conversation
adapter-node stops the HTTP server on SIGTERM/SIGINT but lets the process exit on its own. Nothing called closeDb(), so the idle pool connections kept the process alive for idleTimeoutMillis (30 s) after every shutdown: pods took about as long as the default termination grace period to stop, and the E2E teardown waited 30 s for the app to exit. Close the pool on sveltekit:shutdown, which fires after all in-flight requests completed.
Bohreromir
marked this pull request as ready for review
November 12, 2026 09:27
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
# Conflicts: # src/hooks.server.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
adapter-node stops the HTTP server on SIGTERM/SIGINT but lets the process exit on its own. Nothing called closeDb(), so the idle pool connections kept the process alive for idleTimeoutMillis (30 s) after every shutdown.
This closes the pool on sveltekit:shutdown
Docs
Release note
Checklist
Author
Reviewer
Acceptance