Repository navigation
Fix broken binary preview for KNOWN_BINARY_TYPES - #470
Merged
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
…not renderable For content types in KNOWN_BINARY_TYPES the preview endpoint returns an empty body with X-Preview-Renderable: false. The preview modal ignored that header, decoded the empty body as valid UTF-8 and showed an empty, read-only text editor instead of the binary fallback. Check the header right after the 7z/rar checks and show the fallback. The unit test mock now sends the real binaryPreview() headers, and an E2E test covers an application/avro object.
Bohreromir
force-pushed
the
fix/preview-binary-fallback
branch
from
November 12, 2026 14:21
4e7c408 to
7221c29
Compare
Bohreromir
marked this pull request as ready for review
November 12, 2026 14:23
lfrancke
approved these changes
Nov 12, 2026
lfrancke
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Bohreromir
moved this from Development: In Review
to Development: Done
in Stackable Engineering
Bohreromir
added a commit
to stackabletech/cockpit-clickdummy-demo
that referenced
this pull request
Nov 13, 2026
The fake preview endpoint now answers like the server's binaryPreview() for binary fixtures with a content type (e.g. the gzip clickstream file), so the demo exercises the X-Preview-Renderable: false fallback from stackabletech#470.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
For content types in KNOWN_BINARY_TYPES the preview endpoint returns an empty body with X-Preview-Renderable: false. The preview modal ignored that header, decoded the empty body as valid UTF-8 and showed an empty, read-only text editor instead of the binary fallback.
Check the header right after the 7z/rar checks and show the fallback. The unit test mock now sends the real binaryPreview() headers, and an E2E test covers an application/avro object.
Docs
Release note
Checklist
Author
Reviewer
Acceptance