Repository navigation
docs: Document that changes-ignored is intended for missing ConfigMaps/Secrets - #474
Merged
Merged
Conversation
…s/Secrets The restarter sets the Pod template annotation to "changes-ignored" not only for excluded objects, but also for referenced ConfigMaps/Secrets that don't exist (yet), e.g. because the StatefulSet was created before a mounted Secret. This is intended, but was confusing, so document it in the code and docs.
NickLarsenNZ
approved these changes
Nov 12, 2026
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
Member
There was a problem hiding this comment.
I think the doc is a nice addition. I also think we could maybe rename the value so it's less confusing in the case where you mind expect it to not be ignored (eg: Secret applied after the FooCluster)
NickLarsenNZ
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
Member
Author
|
+1, I was also thinking of renaming it. Making things up, e.g. |
sbernauer
moved this from Development: In Review
to Development: Done
in Stackable Engineering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #410
I first though this is a bug, but once you think about it, it makes sense. Now we document that it's intended.
The restarter sets the Pod template annotation to
changes-ignorednot only for excluded objects, but also for referenced ConfigMaps/Secrets that don't exist (yet), e.g. because the StatefulSet was created before a mounted Secret. This is intended, but was confusing, so document it in the code and docs.Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker